-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature transformation support to FeatureView #4277
Comments
@franciscojavierarceo Just to make sure we're on the same page, do you think we should have a different Also, I think we should probably implement it w/o scheduled materialization at first, because it's not really obvious to me which feast service could do the scheduling for this (flight server seems most logical or maybe we need to add another service altogether). |
I am starting to think having the decorator of feature view type is weird. Instead we could just do something like: @transform(
sources=[credit_data_batch],
entities=[user],
mode="python",
batch_schedule=timedelta(days=1),
schema=[Field("user_id", String), Field("timestamp", Timestamp), Field("current_balance", Float64)],
)
def user_last_balance(transactions):
return some_computation(transactions[["user_id", "timestamp", "current_balance"]]) And maybe in the decorator we have a way to map to when the computation is happening? My view is that we need to provide clarity about when transformations happen (on demand, during a write, or in a stream--i.e., before a write) and I'm not sure the current way does this as obviously. Maybe it does. |
This will be solved #4376 |
Actually this is more general and does not handle the batch transformation use case so keeping this open. The ODFV writes do help for a subset of these items. |
Chaining transformation into a dag which can be reused across FVs would be nice to have. This functionality would reduce code duplication across the feature repo. Here is an example adapted from tecton's transformation API: https://docs.tecton.ai/docs/defining-features/feature-views/transformations#a-feature-view-that-calls-a-pyspark-transformation-passing-two-pyspark-transformation-outputs
|
Is your feature request related to a problem? Please describe.
FeatureViews should support transformations as well.
Describe the solution you'd like
Describe alternatives you've considered
N/A
Additional context
Should behave similar to ODFV and Stream Feature Views and support Python and Pandas.
The text was updated successfully, but these errors were encountered: