Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feast should raise an exception when trying to get a feature set that does not exist #346

Closed
thisisandreeeee opened this issue Dec 4, 2019 · 4 comments · Fixed by #353
Closed

Comments

@thisisandreeeee
Copy link

Expected Behavior

Feast should raise an exception when trying to get a feature set that does not exist, even when the fail_if_missing parameter is specified.

Current Behavior

Feast prints the following error message and does not raise an exception.

GetFeatureSet failed with code "StatusCode.UNKNOWN"

Steps to reproduce

from feast import Client
client = Client(core_url, serving_url)
client.get_feature_set("invalid_feature_set_name", fail_if_missing=True)
@woop
Copy link
Member

woop commented Dec 4, 2019

@thisisandreeeee

I am thinking of just removing this fail_if_missing flag and just always raising an exception here.

Would that work?

@woop
Copy link
Member

woop commented Dec 4, 2019

Actually this applies to most methods. We aren't always raising a gRPC exception, but I think we should be raising that in almost every case and having you wrap it if needed.

@thisisandreeeee
Copy link
Author

That makes sense. We can catch the exception and handle it on our end.

@woop
Copy link
Member

woop commented Dec 8, 2019

The above PR fixes it #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants