Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feast=0.14.0 query_generator() unecessary used twice #1978

Closed
MattDelac opened this issue Oct 27, 2021 · 1 comment
Closed

feast=0.14.0 query_generator() unecessary used twice #1978

MattDelac opened this issue Oct 27, 2021 · 1 comment
Assignees
Labels

Comments

@MattDelac
Copy link
Collaborator

MattDelac commented Oct 27, 2021

Expected Behavior

to_bigquery() should only be calling _upload_entity_df_and_get_entity_schema() once, Otherwise it should not "reupload" the entity_df as it already exists

Current Behavior

I am having a weird issue where when I call to_bigquery(), it's calling query_generator() twice an try to create a tmp dataset in BQ twice using _upload_entity_df_and_get_entity_schema()

Steps to reproduce

  • Feast==0.14.0
offline_job: BigQueryRetrievalJob = historical_retrieval()
tmp_bq_dataset: str = offline_job.to_bigquery()

That's when I import pdb in the lib. We can see that I am getting set_trace(); working twice when I am within the function def query_generator() (this line of code)
And therefore _upload_entity_df_and_get_entity_schema() is called twice with the exact same parameters

image

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

@felixwang9817
Copy link
Collaborator

felixwang9817 commented Oct 28, 2021

Hey @MattDelac, I think #1981 solves this issue? #1981 is included in Feast v0.14.1, so could you check if this issue still occurs if you upgrade?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants