Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: skip-prompts #59

Closed
pascalgrimaud opened this issue May 26, 2020 · 5 comments
Closed

CI: skip-prompts #59

pascalgrimaud opened this issue May 26, 2020 · 5 comments
Assignees
Labels
bug Something isn't working next release

Comments

@pascalgrimaud
Copy link
Collaborator

In the CI, there is the use of yo jhipster-kafka --force --skip-prompts
This command should not generate this:

➜ l src/main/java/io/github/pascalgrimaud/burger/service/kafka/consumer 
total 12K
drwxr-xr-x 2 pgrimaud pgrimaud 4,0K mai   26 12:34 .
drwxr-xr-x 6 pgrimaud pgrimaud 4,0K mai   26 12:34 ..
-rw-r--r-- 1 pgrimaud pgrimaud 1,5K mai   26 12:34 DocumentBankAccountConsumer.java

This file is not related at all to the project, as the command is used for:
--force: to replace all files
--skip-prompts: to use default option in prompt

Linked to #57

@fdelbrayelle fdelbrayelle added the bug Something isn't working label May 26, 2020
@fdelbrayelle fdelbrayelle self-assigned this May 26, 2020
@fdelbrayelle
Copy link
Owner

Why should it be linked with #57 ?
If the prompts are skipped, today as consumers/producers are linked to an entity it should have another behaviour.

@pascalgrimaud
Copy link
Collaborator Author

Linked to #57 because in #57, we should be allowed to use "default" answer. Default answer = without entities selected or a new project without entities yet

@fdelbrayelle
Copy link
Owner

Ok so maybe both issues could be realize simultaneously in this case.

@fdelbrayelle fdelbrayelle removed their assignment May 26, 2020
@pascalgrimaud
Copy link
Collaborator Author

yes it could be, feel free to close this one if you want

@fdelbrayelle
Copy link
Owner

fdelbrayelle commented May 26, 2020

I prefer to keep this opened as the --skip-prompts block could be refactored to be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next release
Projects
None yet
Development

No branches or pull requests

2 participants