From 0ddd0893fff330f0a219ee18afa27bc1e8e25eb8 Mon Sep 17 00:00:00 2001 From: Mark McDonnell Date: Tue, 30 Mar 2021 15:56:33 +0100 Subject: [PATCH 1/2] Ensure passwords are marked as sensitive. --- fastly/block_fastly_service_v1_logging_kafka.go | 1 + 1 file changed, 1 insertion(+) diff --git a/fastly/block_fastly_service_v1_logging_kafka.go b/fastly/block_fastly_service_v1_logging_kafka.go index 434495e47..33954d054 100644 --- a/fastly/block_fastly_service_v1_logging_kafka.go +++ b/fastly/block_fastly_service_v1_logging_kafka.go @@ -124,6 +124,7 @@ func (h *KafkaServiceAttributeHandler) Register(s *schema.Resource) error { Type: schema.TypeString, Optional: true, Description: "SASL Pass", + Sensitive: true, }, } From 4cc6d9657a05f4262e496ddda509eb1edd28d024 Mon Sep 17 00:00:00 2001 From: Mark McDonnell Date: Tue, 30 Mar 2021 16:26:09 +0100 Subject: [PATCH 2/2] Update documentation. --- docs/resources/service_compute.md | 2 +- docs/resources/service_v1.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/resources/service_compute.md b/docs/resources/service_compute.md index 20ef05273..ebcb12181 100644 --- a/docs/resources/service_compute.md +++ b/docs/resources/service_compute.md @@ -453,7 +453,7 @@ Optional: - **auth_method** (String) SASL authentication method. One of: plain, scram-sha-256, scram-sha-512 - **compression_codec** (String) The codec used for compression of your logs. One of: `gzip`, `snappy`, `lz4` - **parse_log_keyvals** (Boolean) Enables parsing of key=value tuples from the beginning of a logline, turning them into record headers -- **password** (String) SASL Pass +- **password** (String, Sensitive) SASL Pass - **request_max_bytes** (Number) Maximum size of log batch, if non-zero. Defaults to 0 for unbounded - **required_acks** (String) The Number of acknowledgements a leader must receive before a write is considered successful. One of: `1` (default) One server needs to respond. `0` No servers need to respond. `-1` Wait for all in-sync replicas to respond - **tls_ca_cert** (String, Sensitive) A secure certificate to authenticate the server with. Must be in PEM format diff --git a/docs/resources/service_v1.md b/docs/resources/service_v1.md index 0ab421ec1..f2d5e0587 100644 --- a/docs/resources/service_v1.md +++ b/docs/resources/service_v1.md @@ -787,7 +787,7 @@ Optional: - **format** (String) Apache style log formatting. - **format_version** (Number) The version of the custom logging format used for the configured endpoint. Can be either 1 or 2. (default: 2). - **parse_log_keyvals** (Boolean) Enables parsing of key=value tuples from the beginning of a logline, turning them into record headers -- **password** (String) SASL Pass +- **password** (String, Sensitive) SASL Pass - **placement** (String) Where in the generated VCL the logging call should be placed. - **request_max_bytes** (Number) Maximum size of log batch, if non-zero. Defaults to 0 for unbounded - **required_acks** (String) The Number of acknowledgements a leader must receive before a write is considered successful. One of: `1` (default) One server needs to respond. `0` No servers need to respond. `-1` Wait for all in-sync replicas to respond