Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more appropriate event sources #4

Closed
farblos opened this issue Apr 2, 2023 · 1 comment · Fixed by #5
Closed

Use more appropriate event sources #4

farblos opened this issue Apr 2, 2023 · 1 comment · Fixed by #5
Labels
bug Something isn't working

Comments

@farblos
Copy link
Owner

farblos commented Apr 2, 2023 •
edited
Loading

As reported in a review, copy-on-select-2 has issues with website v.daum.net/v/20210426063013291.

There is a lot of JavaScript going on there, it seems to interfere with this addon. For example, with uMatrix blocking all but the 1st-party JavaScript, everything works as expected.
@farblos
Copy link
Owner Author

farblos commented Apr 3, 2023

Seems like a valid fix would be to add the event handler on document.body instead of window. At least above site works well then.

This needs some testing, though ...

@farblos farblos changed the title Try to make c-o-s-2 work on news.v.daum.net/v/20210426063013291 Use more appropriate event sources to register handlers to Apr 3, 2023
@farblos farblos changed the title Use more appropriate event sources to register handlers to Use more appropriate event sources Apr 3, 2023
@farblos farblos linked a pull request Apr 4, 2023 that will close this issue
Prepared for release of version 2.3 #5
Merged
@farblos farblos closed this as completed in #5 Apr 4, 2023
@farblos farblos added the bug Something isn't working label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepared for release of version 2.3 farblos/copy-on-select-2
1 participant
@farblos