Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Timezone: Atlantic/Cabo_Verde #2928

Closed
bocguder opened this issue Apr 5, 2024 · 1 comment · Fixed by #2927
Closed

Invalid Timezone: Atlantic/Cabo_Verde #2928

bocguder opened this issue Apr 5, 2024 · 1 comment · Fixed by #2927
Labels
🐞 Issue: Bug

Comments

@bocguder
Copy link

bocguder commented Apr 5, 2024

I am using v3.3.1 and Faker::Address.time_zone returns Atlantic/Cabo_Verde but https://api.rubyonrails.org/classes/ActiveSupport/TimeZone.html list does not contain it.

I think there is a typo and it should be Atlantic/Cape_Verde

Those naming changes are made to be consistent with the new naming of the country, ( #2848 ) however, rails does not support new naming in timezone.
@bocguder bocguder closed this as completed Apr 5, 2024
@andrelaszlo
Copy link
Contributor

@bocguder Maybe reopen since #2927 isn't merged yet?

@andrelaszlo andrelaszlo mentioned this issue Apr 10, 2024
Merged
4 tasks
@bocguder bocguder reopened this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 Issue: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid IANA time zone identifier for Atlantic/Cape_Verde andrelaszlo/faker
2 participants
@andrelaszlo @bocguder