Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of all export = #750

Closed
Shinigami92 opened this issue Apr 1, 2022 · 1 comment
Closed

Get rid of all export = #750

Shinigami92 opened this issue Apr 1, 2022 · 1 comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
vFuture

Comments

@Shinigami92
Copy link
Member

Shinigami92 commented Apr 1, 2022 •
edited
Loading

Replace all export = syntax with export or export default
export = is really bad and for example you cannot export types and interfaces in a file that use this syntax.

This will be a huge breaking change! So we can do this earliest in v7
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Apr 1, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Apr 1, 2022
@Shinigami92 Shinigami92 added this to the Future milestone Apr 1, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Apr 1, 2022
@xDivisionByZerox
Copy link
Member

This issue was resolved in #849.

Repository owner moved this from Todo to Done in Faker Roadmap Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
vFuture
Development

No branches or pull requests
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox