address.secondaryAddress doesn't use faker.definitions.address.secondary_address

[xDivisionByZerox]

Clear and concise description of the problem

The current implementation of faker.address.secondaryAddress uses a hardcoded string array to choose from instead of the definition one. This means locales are ignored for this method.

faker/src/address.ts

Lines 311 to 316 in e62fd15

	secondaryAddress(): string {
	return this.Helpers.replaceSymbolWithNumber(
	// TODO ST-DDT 2022-01-30: this.faker.definitions.address.secondary_address
	this.faker.random.arrayElement(['Apt. ###', 'Suite ###'])
	);
	}

Suggested solution

Use faker.definitions.address.secondary_address instead of the hardcoded string array

secondaryAddress(): string {
  return this.Helpers.replaceSymbolWithNumber(
    this.faker.random.arrayElement(this.faker.definitions.address.secondary_address)
  );
}

Alternative

No response

Additional context

No response

[Shinigami92]

Is this related to #88?

[xDivisionByZerox]

I would say yes. But it breaks down the issue described in #88 in a smaller task that can be picked up.

[xDivisionByZerox]

I provided #680 to fix this.