Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title and buttons on homepage have gone blue? #2626

Closed
matthewmayer opened this issue Jan 28, 2024 · 9 comments · Fixed by #2627 or #2632
Closed

Title and buttons on homepage have gone blue? #2626

matthewmayer opened this issue Jan 28, 2024 · 9 comments · Fixed by #2627 or #2632
Assignees
Labels
c: docs Improvements or additions to documentation
Milestone

Comments

@matthewmayer
Copy link
Contributor

matthewmayer commented Jan 28, 2024

Has some CSS gone astray? Title is now blue and the Browse API button is quite hard to read.

https://fakerjs.dev/

Screenshot 2024-01-28 at 20 21 45

https://web.archive.org/web/20231129222728/https://fakerjs.dev/

Screenshot 2024-01-28 at 20 21 36
@Shinigami92
Copy link
Member

It's just a redesign of Vitepress (we are mostly using the default theme)
Only the "Browse API" Button is slightly customized by us
Might need to use the text-color of the border like before

@Shinigami92
Copy link
Member

AHA! the issue is that I only designed the button in dark mode, not respecting light mode at all 😆
will fix it

@matthewmayer matthewmayer transferred this issue from faker-js/awesome-faker Jan 28, 2024
@matthewmayer
Copy link
Contributor Author

sorry added in wrong repo, moved here

@matthewmayer
Copy link
Contributor Author

i thought the green looked nicer :)

looks like you can easily override the main theme colors by overriding some CSS vars, if we want the green back (or another color)

image

@Shinigami92 Shinigami92 self-assigned this Jan 28, 2024
@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Jan 28, 2024
@Shinigami92 Shinigami92 added this to the v8.x milestone Jan 28, 2024
@Shinigami92 Shinigami92 linked a pull request Jan 28, 2024 that will close this issue
@Shinigami92
Copy link
Member

If you like to change the color and want to customize the default style, pls open another PR

I just fixed the brand button's text in light mode

@Shinigami92
Copy link
Member

@matthewmayer also ask yourself 2 questions 🙂

  1. were you just used to the previous colors?
  2. is it worth for you to maintain override of Vitepress design 🙃

But I wont hold you back 🚀

@matthewmayer
Copy link
Contributor Author

  1. Yes
  2. Yes

🤣

Will open a new PR

@xDivisionByZerox
Copy link
Member

  1. were you just used to the previous colors?

To prevent personal oppinion, we should maybe define a design spec for Faker's "branding". I'll add the point to the next meetings discussion list.

@matthewmayer
Copy link
Contributor Author

could use the reds from the stripe of the hat perhaps

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation
Projects
None yet
3 participants