Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multipleOf to faker.number.int #2584

Closed
matthewmayer opened this issue Dec 20, 2023 · 5 comments · Fixed by #2586
Closed

add multipleOf to faker.number.int #2584

matthewmayer opened this issue Dec 20, 2023 · 5 comments · Fixed by #2586
Assignees
Labels
c: feature Request for new feature m: number Something is referring to the number module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@matthewmayer
Copy link
Contributor

Originally posted by @matthewmayer in #2581 (comment)

Similar to faker.number.float, faker.number.int should also support a multipleOf parameter

@matthewmayer matthewmayer added m: number Something is referring to the number module c: feature Request for new feature labels Dec 20, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision labels Dec 20, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 20, 2023
@Shinigami92
Copy link
Member

Personal opinion: I'm not sure if this is needed at all, just for symmetry is not a so good reason 🤔
We could discuss this in one of the next meetings

@matthewmayer
Copy link
Contributor Author

I think the main advantage is it could be used in helpers.fake patterns for other methods.

@Shinigami92
Copy link
Member

I think the main advantage is it could be used in helpers.fake patterns for other methods.

This is a really good point 👍

@matthewmayer
Copy link
Contributor Author

For example in the new food module there was a description like "400g of delicious steak"

A menu might realistically have a 350g or 400g steak but not a 362g steak.

@ST-DDT
Copy link
Member

ST-DDT commented Feb 15, 2024

Team Decision

  • We want this

@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: number Something is referring to the number module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants