-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop deprecating and changing everything for each version #2288
Comments
Thanks for telling us about the problems you have when using Faker. I would like to use this opportunity to ask you (and the community) these questions to better understand you:
Thanks for your feedback. |
@zacharytyhacz Deprecations and code removals are normal when moving from one major version to the next. Code always evolves, and it's not that hard to do a string search and replace for updating the methods. faker is an amazing lib where maintainers pour a lot of time and effort in it, so that should be appreciated properly. Without thinking too much about it right now, our team would care most about having the whole project be tree-shakable properly, this open issue seems related: #1791 It happens easily to accidentally end up with faker in the prod bundle and then the application size blows up like crazy. |
I would also add that Faker is not the kind of library where its vital to upgrade frequently. It doesn't have any dependencies and there are very unlikely to be security issues with using an older version. Most updates are minor improvements to locale data, small bugfixes or improvements to make the API more consistent. So if you have a working Faker x.y.z version unless you need a specific new feature there's no big hurry to upgrade to the latest version or deal with deprecations immediately. |
I will be closing this issue since no more discussion or suggestions are ongoing, but we keep it in mind when changing faker's code. |
The deprecation warnings are getting insane. Once I upgrade and refactor usage, i only upgrade to be known it's all deprecated AGAIN.
Using eslint-deprecation rule
The text was updated successfully, but these errors were encountered: