Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for https://placeholder.com as image provider #1111

Closed
Shinigami92 opened this issue Jun 27, 2022 · 3 comments
Closed

Add support for https://placeholder.com as image provider #1111

Shinigami92 opened this issue Jun 27, 2022 · 3 comments
Assignees
@Devdre1909
Labels
c: feature Request for new feature m: image Something is referring to the image module

Comments

@Shinigami92
Copy link
Member

Clear and concise description of the problem

Add support for https://placeholder.com

Suggested solution

Create random generated image URLs based on deterministic and seed via https://placeholder.com

Alternative

No response

Additional context

I want to create simple grey or coloured placeholder images for my company's project.
I will used them as thumbnails for a video. Also at least the aspect ratio is important to be controlled.
@Shinigami92 Shinigami92 added the s: pending triage Pending Triage label Jun 27, 2022
@ejcheng ejcheng added c: feature Request for new feature and removed s: pending triage Pending Triage labels Jun 28, 2022
@Devdre1909
Copy link
Contributor

Hi @import-brain.
Can I work on this if anyone isn’t working on it?, and is there a proposed implementation?

@ejcheng
Copy link
Member

ejcheng commented Jul 23, 2022

Hi @import-brain.

Can I work on this if anyone isn’t working on it?, and is there a proposed implementation?

Sure! I don't believe there is a proposed implementation, but I'll assign this to you now.

@Shinigami92, just checking, this is open for contributions, right?

@Devdre1909 Devdre1909 mentioned this issue Jul 24, 2022
Merged
@xDivisionByZerox xDivisionByZerox added the m: image Something is referring to the image module label Jul 29, 2022
@xDivisionByZerox
Copy link
Member

This has been implemented in #1186.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Devdre1909 Devdre1909

Labels
c: feature Request for new feature m: image Something is referring to the image module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Shinigami92 @Devdre1909 @ejcheng @xDivisionByZerox