Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize for calculating correlations #203

Open
Shine226 opened this issue May 31, 2021 · 2 comments
Open

Optimize for calculating correlations #203

Shine226 opened this issue May 31, 2021 · 2 comments
Assignees
@brownsarahm @Shine226
Labels
enhancement New feature or request

Comments

@Shine226
Copy link
Collaborator

Current code is using corr to calculate correlation matrix. This approach is not good for asymmetrical case (e.g., 1 dependent and 10 independent variable).
corr_mat = data_df[corr_var_list].corr(method=self.corrtype)
@brownsarahm brownsarahm added the enhancement New feature or request label Jun 1, 2021
@hatrick36
Copy link
Contributor

Hi Shine, have you already started working on this issue?

@Shine226
Copy link
Collaborator Author

Shine226 commented Jun 3, 2021

I have some simple alternative code for this issue. But I am not working thoroughly on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brownsarahm brownsarahm

@Shine226 Shine226

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brownsarahm @Shine226 @hatrick36