From 52c7250c431c10c3df36300869a1eb98dbf41a6d Mon Sep 17 00:00:00 2001 From: Stephan Huber Date: Tue, 3 Dec 2024 20:00:35 +0100 Subject: [PATCH 1/2] fix: Fix for npm-method for not picking up the build command setting (Fixes #351) --- src/Method/NpmMethod.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Method/NpmMethod.php b/src/Method/NpmMethod.php index 9d93da22..5ddae929 100644 --- a/src/Method/NpmMethod.php +++ b/src/Method/NpmMethod.php @@ -55,7 +55,7 @@ public function validateConfig( public function resetPrepare(HostConfig $host_config, TaskContextInterface $context) { $this->runCommand($host_config, $context, 'install'); - $this->runCommand($host_config, $context, $host_config->get('npmBuildCommand')); + $this->runCommand($host_config, $context, $host_config->getProperty('npm.buildCommand')); } public function installPrepare(HostConfig $host_config, TaskContextInterface $context) From 349cc64440a2f9cd7675058e8ecb255147957ba1 Mon Sep 17 00:00:00 2001 From: Stephan Huber Date: Tue, 3 Dec 2024 20:01:11 +0100 Subject: [PATCH 2/2] chore(release): 3.8.35 --- CHANGELOG.md | 7 +++++++ package.json | 2 +- src/Utilities/Utilities.php | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5728ffac..4768aa8a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,13 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +### [3.8.35](https://github.com/factorial-io/phabalicious/compare/3.8.34...3.8.35) (2024-12-03) + + +### Bug Fixes + +* Fix for npm-method for not picking up the build command setting (Fixes [#351](https://github.com/factorial-io/phabalicious/issues/351)) ([52c7250](https://github.com/factorial-io/phabalicious/commit/52c7250c431c10c3df36300869a1eb98dbf41a6d)) + ### [3.8.34](https://github.com/factorial-io/phabalicious/compare/3.8.33...3.8.34) (2024-11-11) diff --git a/package.json b/package.json index 3e4541aa..6b17a363 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "phabalicious", - "version": "3.8.34", + "version": "3.8.35", "main": "index.js", "repository": "https://github.com/factorial-io/phabalicious.git", "author": "Stephan Huber ", diff --git a/src/Utilities/Utilities.php b/src/Utilities/Utilities.php index 78d2fb46..51c92c07 100644 --- a/src/Utilities/Utilities.php +++ b/src/Utilities/Utilities.php @@ -13,7 +13,7 @@ class Utilities { - const FALLBACK_VERSION = '3.8.34'; + const FALLBACK_VERSION = '3.8.35'; const COMBINED_ARGUMENTS = 'combined'; const UNNAMED_ARGUMENTS = 'unnamedArguments';