Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pepper "samples_dropped" attributes into appropriate facile_frame manipulation functions #25

Open
lianos opened this issue Aug 17, 2023 · 0 comments
Assignees

Comments

@lianos
Copy link
Member

lianos commented Aug 17, 2023

When querying a multi-modal FacileDataStore, there are times when you have facile_frame used as an input to a function, which also takes an "assay_name" parameter.

It's possible that the samples you put in don't all have assay data from "assay_name" and the result you get back will either have NA values, or it drops the samples with missing assay data altogether.

I've introduced a drop_samples = TRUE parameter to these functions, which is to say that the default behavior is to just drop the samples that don't have the assay data. The dropped samples are returned in an attr(out, "samples_dropped") attribute

You can get the samples that were dropped in such a way by calling samples(out, dropped = TRUE)

The fetch_assay_data.FacileDataSet@multi-modal-unit-testing [link] and assay_sample_info.FacileDataSet@multi-modal-unit-testing [link] give you an idea of what we're talking aboot.

@lianos lianos self-assigned this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant