From b417572105660ee54f2089c654234dc378bb337d Mon Sep 17 00:00:00 2001 From: Masha Basmanova Date: Mon, 13 Nov 2023 13:36:53 -0800 Subject: [PATCH] Relax column count check in PrestoSerializer (#7524) Summary: Pull Request resolved: https://github.com/facebookincubator/velox/pull/7524 Some call sites deserialize only a subset of columns. Relax the check to avoid breaking these. Investigate and fix these call sites, then restore the check as a follow-up. Reviewed By: xiaoxmeng Differential Revision: D51230660 fbshipit-source-id: de53d4e4749b9a878eefba6312226764643e576b --- velox/serializers/PrestoSerializer.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/velox/serializers/PrestoSerializer.cpp b/velox/serializers/PrestoSerializer.cpp index 262e54acd09d..3fd91fef2012 100644 --- a/velox/serializers/PrestoSerializer.cpp +++ b/velox/serializers/PrestoSerializer.cpp @@ -2339,7 +2339,8 @@ void PrestoVectorSerde::deserialize( const auto& childTypes = type->asRow().children(); if (!needCompression(*codec)) { const auto numColumns = source->read(); - VELOX_USER_CHECK_EQ( + // TODO Fix call sites and tighten the check to _EQ. + VELOX_USER_CHECK_GE( numColumns, type->size(), "Number of columns in serialized data doesn't match "