Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dual License is Ambiguous #2945

Closed
hinton-mgi opened this issue Dec 22, 2021 · 1 comment · Fixed by #2981
Closed

Dual License is Ambiguous #2945

hinton-mgi opened this issue Dec 22, 2021 · 1 comment · Fixed by #2981
Labels
release-blocking Must be done by the release

Comments

@hinton-mgi
Copy link

README.md does not indicate whether both BSD and GPLv2 must be followed, or if one or the other may be chosen. I understand that it is intended to be the latter, according to issue #1181 and according to comments at the top of most source files. However there are source files that do not make this indication, e.g. lib/decompress/huf_decompress_amd64.S.

Intent is not enough for some. Please edit README.md to make this unambiguous.
@terrelln terrelln added the release-blocking Must be done by the release label Jan 5, 2022
@terrelln
Copy link
Contributor

terrelln commented Jan 5, 2022

We'll fix this in our next release. lib/decompress/huf_decompress_amd64.S is intended to have exactly the same license header as our other files in lib/.

We have automation to check our licensing, but it doesn't cover .S extensions. So we'll have to fix that up.

@terrelln terrelln mentioned this issue Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-blocking Must be done by the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[license] Fix license header of huf_decompress_amd64.S terrelln/zstd
2 participants
@terrelln @hinton-mgi