Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-test-renderer does not install dependencies on npm v2 #8466

Closed
kweiberth opened this issue Nov 30, 2016 · 5 comments
Closed

react-test-renderer does not install dependencies on npm v2 #8466

kweiberth opened this issue Nov 30, 2016 · 5 comments

Comments

@kweiberth
Copy link
Contributor

kweiberth commented Nov 30, 2016

I'm currently using react-test-renderer version 15.4.1 and npm version 2.15.9 and jest version 17.0.3. When running tests that use react-test-renderer, I'm seeing this error:

Cannot find module 'object-assign' from 'ReactTestRenderer.js'

at Resolver.resolveModule (node_modules/jest/node_modules/jest-cli/node_modules/jest-resolve/build/index.js:151:17)
at Object.<anonymous> (node_modules/react-test-renderer/lib/ReactTestRenderer.js:15:15)
at Object.<anonymous> (node_modules/react-test-renderer/index.js:3:18)

Is this an issue with npm v2?

@gaearon
Copy link
Collaborator

gaearon commented Nov 30, 2016

Good catch. I think we need to add "object-assign": "^4.1.0", to dependencies here (and add dependencies section itself). Wanna make a PR?

Technically addon packages should also get it, I think.

@kweiberth
Copy link
Contributor Author

Thanks for the response. Yes I will make a PR.

@kweiberth
Copy link
Contributor Author

@gaearon here's a PR to fix this issue: #8467

Though I'm unsure if addons needs fbjs as well.

@pedrottimark
Copy link
Contributor

Noticed while searching: it looks like this issue can be closed now :)

@aweary
Copy link
Contributor

aweary commented Feb 15, 2017

Thanks @pedrottimark!

@aweary aweary closed this as completed Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants