Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Dynamic Context #4555

Closed
alexprice1 opened this issue Aug 4, 2015 · 2 comments
Closed

Question: Dynamic Context #4555

alexprice1 opened this issue Aug 4, 2015 · 2 comments

Comments

@alexprice1
Copy link

I am trying to have locality specified throughout my app. I thought that using context could be a good solution for this. To achieve this, I need to let the user dynamically change their locale.

Should dynamically changing the context have any negative consequences? I have tested it, and it works, but want to make sure there will not be any negative consequences.

@alexprice1 alexprice1 changed the title Dynamic Context Question: Dynamic Context Aug 4, 2015
@jimfb
Copy link
Contributor

jimfb commented Aug 4, 2015

Locale is one of the intended use cases of context, and dynamically changing it (occasionally) is expected (and supported to the extent that context is supported). Keep in mind that changing context may be somewhat expensive, so avoid setting it every frame or whatever, but yeah.

Only known bug that you might run into is: #4344

Closing this out, since we use github issues to track bugs in React, and this is a question rather than a bug. A better place for questions like this would be discuss.reactjs.org or StackOverflow.

@alexprice1
Copy link
Author

Got it. Thanks for the help!

On Aug 4, 2015, at 5:37 PM, Jim notifications@github.com wrote:

Locale is one of the intended use cases of context, and dynamically changing it (occasionally) is expected (and supported to the extent that context is supported). Keep in mind that changing context may be somewhat expensive, so avoid setting it every frame or whatever, but yeah.

Only known bug that you might run into is: #4344

Closing this out, since we use github issues to track bugs in React, and this is a question rather than a bug. A better place for questions like this would be discuss.reactjs.org or StackOverflow.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants