-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Should not already be working" in Firefox after a breakpoint/alert #17355
Comments
Is there any way you can provide a code sample that reproduces the problem? That error should only occur if there's a bug in React, so it'd be very helpful if we could reproduce. |
I see the same error message in sentry, and the breadcrumbs show an "out of memory" error - and then further down some react errors. Not sure if it'll be useful, but here's some the breadcrumbs. OS: Windows 7,
|
To add some more data points: I'm not seeing out of memory errors on my end. We downgraded to React 16.10.2 and are still seeing errors. Will keep downgrading and report back. Also to the FB team, we're happy to share Sentry reports with you. |
I just updated my comment to include the React version (v16.9.0) Edit: Also I searched outside of the last 24h and we've received this error many times. Browser: Firefox 70.0 & 68.0 Browser: Firefox 70.0 Browser: IE 11 |
I am getting the exact same sentry reports, but unable to reproduce the same in VM environment. |
We're seeing this in Sentry, too. OS: Windows 10 AFAICT it happens before the user did anything; here's the stack trace:
|
@gzzo Are you by any chance in any of your I was getting the error |
Interesting. We do call setState in a couple of
|
Hello, We've also noticed this error in our sentry. It's only occurred once so far under these conditions: OS: Windows 10 The stack trace does not appear to provide much additional info:
|
I had this same issue. Was not a problem in Chrome however I received a blank screen and the error. Error: Should not already be working. |
We also experience this issue. We have tons of cases were we call one or multiple 'setState' in 'componentDidMount'. It has never been an issue. Moving these calls to other places is not an option. |
I am able to reproduce the issue when stepping through a function after a breakpoint in an otherwise working development build application. Console output: |
We also experience this issue since we bumped React. React 16.12.0 The stack traces point us to this function call More detail
|
Any movement on this? I am also getting these errors in FireFox (73.0.1 (64-bit) but not in Chrome (Version 80.0.3987.122 (Official Build) (32-bit) It is happening when trying to initialize data from props:
Error:
|
I got the same error 'Should not already be working' because I created a pipe write stream in my dataActions, shifting the function to a util file outside the action file fixed the issue for me. |
I got the same error reported on sentry Error: Should not already be working.
at Lj(/node_modules/react-dom/cjs/react-dom.production.min.js:223:129)
at b(/node_modules/react-dom/cjs/react-dom.production.min.js:121:115)
at Lf(/node_modules/scheduler/cjs/scheduler.production.min.js:18:437)
at fg(/node_modules/react-dom/cjs/react-dom.production.min.js:120:325)
at ig(/node_modules/react-dom/cjs/react-dom.production.min.js:121:61)
at X(/node_modules/scheduler/cjs/scheduler.production.min.js:17:184)
at hf2P/S.port1.onmessage(/node_modules/scheduler/cjs/scheduler.production.min.js:14:64) User-Agent:
Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0 I can point to the live website where this error was reported but I cannot reproduce it manually. |
Getting this error in React Native as well. Based on my understanding of this reddit comment. I think if user land code throws an error in componentDidMount, React does not reset state and next time render occurs, this Error "Should not already be working" gets thrown. |
I has this issue and the problem was related toan ajax call with jquery made in componentDidMount with async parameter to false, this causes some issues with latest react release to synchronise the state I assume. setting async to true solved the issue |
This happens to me if I set a breakpoint in |
Ok, at least in my case, this looks like a... thread-safety issue? Firefox has no problem running JavaScript event handlers while stopped at a breakpoint, causing all kinds of bizarre behavior. I must've missed the memo that JavaScript is no longer single-threaded. |
@aweary Can we add some more diagnostic info, like what component React is working on, maybe that might give us some information on where to concentrate. |
Just got this error in a React Native project. |
@cristianoccazinsp I've created an issue on react-native repo as well, because its a different renderer: facebook/react-native#28948 |
Same here if we run {
componentDidMount() {
setTimeout(() => {
$.ajax();
}, 300);
}
} |
Hi @acdlite (sorry for tagging you here), |
Hi Team, I am facing this issue now in firefox browser. How to resolve this issue ? Any suggestion please? |
My error reporting system has been reporting me this error in production for my react app https://twisti.app. anyone know what is causing it or how to fix it? the error message is not very helpful user info:
error:
trace:
|
same with me, when i set a breakpoint between setState and Axios request in componentDidUpdate, this error will appear. But if i delete the breakpoint, everything is fine. |
Also seeing this reported all of a sudden by my application monitoring service. |
Error shouldd not be working in firebox or in brave problem code was trying to open trying to open a window (for polling login) in componentDidMount. Problem goes away when I wrap the call in setTimeout. |
hi, I want to work on any good first issue but cannot find any unassigned isue, can anyone help with it? |
Hello @gzzo, I'm here first time and would like to contribute this project. |
const Demo=()=>{ render( {count}+ - )} export default Demo solution: const Demo=()=>{ return( {count}+ - )} export default Demo we only use return method in function, if we use insted of render that error "should not already be working" will occur |
Hello, this is going to be my first contribution and also it's a good first issue. I am exciting to work on it. Can u assign this task to me @gzzo |
also happening for me when React tries to refresh state, version info: |
i have a problem with firefox 115 |
Hello @Abhishekzod007 , are you still working on this? |
Hmm, interesting first issue indeed. |
Hello , I'm here for the first time and would like to contribute this project. |
please read the Contributing Guide if you didn't. |
I just started facing this issue, in react-native, happening only while using |
same here with firefox 127 and react 18 |
Issue Summary: "Should not already be working" in FirefoxDescriptionAfter upgrading to React 16.11, users encounter the error message: "Error: Should not already be working". This issue primarily occurs in an older version of Chrome (68.0.3440) on Windows 7. Affected Versions
Reproduction
Additional NotesFurther information regarding this error is limited, and no definitive solutions have been found as of yet. |
Hi, may you share some scheenshots? I want to make sure working the exactly issue. Thanks. |
I would like to give you the task of investigating and resolving the "Should not already be working" error that occurs in React 16.11. This error is specific to older environments, such as Chrome 68.0.3440 on Windows 7, and has been reported multiple times via Sentry logs. Here is a step-by-step outline for addressing the problem: Version Check: Update to the latest version that belongs in the 16.x series, checking that both React and ReactDOM match. Upgrade to an entirely new React version as part of troubleshooting this bug. |
We got ChatGPT Indians before GTA 6. |
Firefox 134, react 18.3.1, still seeing this issue 😞 |
I would like to work on this issue. Could you please assign it to me? |
@amirmousazadeh-1984 you have now been assigned this issue. Please submit a PR by the end of this year. |
any updates? |
It's been 5 years, and it's still not a Good First Issue. |
Thank you |
Send me an email for further guidance dbdanishbutt@gmail.com |
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
I'm seeing "Error: Should not already be working" after upgrading to React 16.11
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
This is exclusively happening on an older version of Chrome, 68.0.3440 on Windows 7
I was unable to reproduce this in a VM environment but our Sentry is getting littered with these errors.
I know it's a long shot, but I wasn't able to find any information about this error anywhere, just a reference in the error codes file in react, so thought it would be a good idea to report this just in case. Curious if anyone has seen this.
The text was updated successfully, but these errors were encountered: