Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cannot set property 'return' of null" while using Suspense and lazy #14162

Closed
chrisvasz opened this issue Nov 9, 2018 · 1 comment
Closed

Comments

@chrisvasz
Copy link

chrisvasz commented Nov 9, 2018

Do you want to request a feature or report a bug?

bug

What is the current behavior?

Given code like this:

<Suspense fallback={...}>
  {this.state.render && <LazyComponent />}
</Suspense>

my LazyComponent should download and render when I run this.setState({ render: true }). Instead, I get an internal React error about setting property null of return.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:

https://jsfiddle.net/cq9hfwe8/1/. Open the console to see the error message.

What is the expected behavior?

The combination of Suspense and lazy defer downloading and rendering my component until I set a state variable to true.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

Tried on Windows in Chrome 71, React 16.6.1.

@acdlite
Copy link
Collaborator

acdlite commented Nov 9, 2018

@chrisvasz My bad! That's what I get for using any. #14164 fixes it. Will release a patch within the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants