From 38900cc7cad8906c19515c78fd082637c2046fbd Mon Sep 17 00:00:00 2001 From: Nate Norberg Date: Fri, 27 May 2016 16:23:05 -0600 Subject: [PATCH] Added more specific warning for using onDblClick instead of onDoubleClick (#6881) --- .../dom/shared/__tests__/ReactDOMComponent-test.js | 11 +++++++++++ .../shared/stack/event/EventPluginRegistry.js | 5 +++++ 2 files changed, 16 insertions(+) diff --git a/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js b/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js index 9dfea6dee139b..6c20afbd2fa79 100644 --- a/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js +++ b/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js @@ -163,6 +163,17 @@ describe('ReactDOMComponent', function() { ); }); + it('should warn for onDblClick prop', function() { + spyOn(console, 'error'); + var container = document.createElement('div'); + ReactDOM.render(
{}} />, container); + expect(console.error.calls.count(0)).toBe(1); + expect(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe( + 'Warning: Unknown event handler property onDblClick. Did you mean `onDoubleClick`?\n in div (at **)' + ); + }); + + it('should warn about styles with numeric string values for non-unitless properties', function() { spyOn(console, 'error'); diff --git a/src/renderers/shared/stack/event/EventPluginRegistry.js b/src/renderers/shared/stack/event/EventPluginRegistry.js index f6830e58869da..cb3fdf2281bef 100644 --- a/src/renderers/shared/stack/event/EventPluginRegistry.js +++ b/src/renderers/shared/stack/event/EventPluginRegistry.js @@ -132,6 +132,11 @@ function publishRegistrationName(registrationName, PluginModule, eventName) { var lowerCasedName = registrationName.toLowerCase(); EventPluginRegistry.possibleRegistrationNames[lowerCasedName] = registrationName; + + + if (registrationName === 'onDoubleClick') { + EventPluginRegistry.possibleRegistrationNames.ondblclick = registrationName; + } } }