[RN][Windows] Do not install CMake on Windows machine #48122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b122ee to
3780643
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 00d5cae. |
|
This pull request was successfully merged by @cipolleschi in 00d5cae When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Dec 6, 2024
Summary: GHA to build HermesC for windows are failing because the machines comes with a different CMake version already. Let's try not to install Cmake and use the one provided by the machine. ## Changelog: [Internal] - Pull Request resolved: #48122 Test Plan: GHA {F1973187648} Reviewed By: alanleedev Differential Revision: D66825216 Pulled By: cipolleschi fbshipit-source-id: 9a9376a5409e192195a6b6cc25b4d58cb47f15da
|
This pull request was successfully merged by @cipolleschi in a0be560 When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Dec 6, 2024
Summary: GHA to build HermesC for windows are failing because the machines comes with a different CMake version already. Let's try not to install Cmake and use the one provided by the machine. ## Changelog: [Internal] - Pull Request resolved: #48122 Test Plan: GHA {F1973187648} Reviewed By: alanleedev Differential Revision: D66825216 Pulled By: cipolleschi fbshipit-source-id: 9a9376a5409e192195a6b6cc25b4d58cb47f15da
|
This pull request was successfully merged by @cipolleschi in 88c5b4f When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
GHA to build HermesC for windows are failing because the machines comes with a different CMake version already.
Let's try not to install Cmake and use the one provided by the machine.
Changelog:
[Internal] -
Test Plan:
GHA