From e5e39b461b057e4937ad19695d7958c7914c359a Mon Sep 17 00:00:00 2001 From: Andres Suarez Date: Sun, 1 Feb 2015 21:18:45 -0500 Subject: [PATCH 1/2] Fix typo in ListView comments --- Libraries/Components/ListView/ListView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/Components/ListView/ListView.js b/Libraries/Components/ListView/ListView.js index 844400d66a9a8c..45539586be4424 100644 --- a/Libraries/Components/ListView/ListView.js +++ b/Libraries/Components/ListView/ListView.js @@ -104,7 +104,7 @@ var ListView = React.createClass({ initialListSize: PropTypes.number, /** * Called when all rows have been rendered and the list has been scrolled - * to within onEndReachedThreashold of the bottom. The native scroll + * to within onEndReachedThreshold of the bottom. The native scroll * event is provided. */ onEndReached: PropTypes.func, From 76b2bafdbd52ef28917a53e64238b6d917e60559 Mon Sep 17 00:00:00 2001 From: Andres Suarez Date: Sun, 1 Feb 2015 21:19:44 -0500 Subject: [PATCH 2/2] Fix "key" prop warnings in UIExplorer --- Examples/UIExplorer/LayoutExample.js | 2 +- Examples/UIExplorer/ScrollViewExample.js | 2 +- Examples/UIExplorer/UIExplorerList.js | 4 ++-- Examples/UIExplorer/createExamplePage.js | 3 ++- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Examples/UIExplorer/LayoutExample.js b/Examples/UIExplorer/LayoutExample.js index 5c8c976a5a8bc4..746ef0ac6a2f79 100644 --- a/Examples/UIExplorer/LayoutExample.js +++ b/Examples/UIExplorer/LayoutExample.js @@ -124,7 +124,7 @@ var LayoutExample = React.createClass({ - {'oooooooooooooooo'.split('').map(() => )} + {'oooooooooooooooo'.split('').map((char, i) => )} diff --git a/Examples/UIExplorer/ScrollViewExample.js b/Examples/UIExplorer/ScrollViewExample.js index e9d9c8f930fb0b..95baa6120cae8e 100644 --- a/Examples/UIExplorer/ScrollViewExample.js +++ b/Examples/UIExplorer/ScrollViewExample.js @@ -54,7 +54,7 @@ var Thumb = React.createClass({ var THUMBS = ['https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-ash3/t39.1997/p128x128/851549_767334479959628_274486868_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851561_767334496626293_1958532586_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-ash3/t39.1997/p128x128/851579_767334503292959_179092627_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851589_767334513292958_1747022277_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851563_767334559959620_1193692107_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851593_767334566626286_1953955109_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851591_767334523292957_797560749_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851567_767334529959623_843148472_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851548_767334489959627_794462220_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851575_767334539959622_441598241_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-ash3/t39.1997/p128x128/851573_767334549959621_534583464_n.png', 'https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-prn1/t39.1997/p128x128/851583_767334573292952_1519550680_n.png']; THUMBS = THUMBS.concat(THUMBS); // double length of THUMBS -var createThumbRow = (uri, i) => ; +var createThumbRow = (uri, i) => ; var styles = StyleSheet.create({ scrollView: { diff --git a/Examples/UIExplorer/UIExplorerList.js b/Examples/UIExplorer/UIExplorerList.js index 207ad2d66b8d0b..e1b253c21b711f 100644 --- a/Examples/UIExplorer/UIExplorerList.js +++ b/Examples/UIExplorer/UIExplorerList.js @@ -44,10 +44,10 @@ var UIExplorerList = React.createClass({ ); }, - _renderRow: function(example) { + _renderRow: function(example, i) { invariant(example.title, 'Example must provide a title.'); return ( - + this._onPressRow(example)}> diff --git a/Examples/UIExplorer/createExamplePage.js b/Examples/UIExplorer/createExamplePage.js index 070395dad33177..39ed81133c3775 100644 --- a/Examples/UIExplorer/createExamplePage.js +++ b/Examples/UIExplorer/createExamplePage.js @@ -20,7 +20,7 @@ var createExamplePage = function(title, exampleModule) { description: exampleModule.description, }, - getBlock: function(example) { + getBlock: function(example, i) { // Hack warning: This is a hack because the www UI explorer requires // renderComponent to be called. var originalRenderComponent = React.renderComponent; @@ -37,6 +37,7 @@ var createExamplePage = function(title, exampleModule) { React.render = originalRender; return ( {renderedComponent}