Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile: RCTFabricUIManagerWrapper.h is included when using Cocoapods [0.55.x regression] #18741

Closed
3 tasks done
almostintuitive opened this issue Apr 7, 2018 · 4 comments
Labels
Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Resolution: Fixed A PR that fixes this issue has been merged. Resolution: Locked This issue was locked by the bot.

Comments

@almostintuitive
Copy link

The file RCTFabricUIManagerWrapper.h is included included when using Cocoapods (the local "React" pod). RCTFabricUIManagerWrapper.h does not compile: it throws an error that folly-config.h is not found.

The app builds fine with react-native 0.54.x.

The root cause of the problem is that this specific file is unintentionally included among the compiled files. According to @fkgozali 's comment on #17764

Environment

Environment:
OS: macOS High Sierra 10.13.3
Node: 9.10.1
Yarn: 1.5.1
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.3 Build version 9E145
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.55.1 => 0.55.1

Steps to Reproduce

  1. Create a new Xcode project
  2. Follow the guide how to integrate react-native into an existing project
  3. Run the app

Expected Behavior

The app builds without an error.

Actual Behavior

The app does not compile

@react-native-bot react-native-bot added the Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. label Apr 7, 2018
@almostintuitive
Copy link
Author

@fkgozali originally CCd @shergin & @hramos, so I'll do that here as well.

@fkgozali
Copy link
Contributor

fkgozali commented Apr 7, 2018

Thanks for the report. I think this was addressed with #18688 (now in master).

@hramos hramos closed this as completed Apr 9, 2018
@hramos hramos added the Resolution: Fixed A PR that fixes this issue has been merged. label Apr 9, 2018
@fkgozali
Copy link
Contributor

fkgozali commented Apr 9, 2018

@hramos: may want to get that fix picked to 0.55 or whatever the latest release is?

@hramos
Copy link
Contributor

hramos commented Apr 9, 2018

@fkgozali for sure. @ptomasroos requested this be cherry-picked into 0.55 here: react-native-community/releases#11 (comment)

@facebook facebook locked as resolved and limited conversation to collaborators Apr 9, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Resolution: Fixed A PR that fixes this issue has been merged. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants