Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualizedList populated with getItem() only displaying the first 10 items #13509

Closed
agmathew opened this issue Apr 14, 2017 · 6 comments
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@agmathew
Copy link

agmathew commented Apr 14, 2017

Description

When populating a VirtualizedList using getItem() (i.e. not using data), the list only shows the first 10 items even if getItemCount() returns a number more than 10. This seems to happen irrespective of the setting of initialNumberToRender and windowSize. I'd expect that you would be able to see all items in the list.

Reproduction Steps and Sample Code

export default class ListTest extends Component {
  render() {
    return (
      <View>
        <VirtualizedList
          initialNumberToRender={20}
          windowSize={21}
          getItemCount={(data) => 365}
          getItem={(data, index) => {
            return { key: index };
          }}
          keyExtractor={(item, index) => {
            return item.key;
          }}
          renderItem={({ item, index }) => {
            return (
              <View style={{height:50}}>
                <Text>{item.key}</Text>
              </View>
            );
          }}
        />
      </View>
    );
  }
}

Solution

I peeked at the source code, but couldn't find a clear fix.

Additional Information

  • React Native version: 0.43.3
  • Platform: iOS
  • Development Operating System: MacOS
  • Dev tools: XCode 8.2.1
@hramos
Copy link
Contributor

hramos commented Jul 25, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 25, 2017
@hramos hramos closed this as completed Jul 25, 2017
@gastonmorixe
Copy link

+1

@gastonmorixe
Copy link

The property is called initialNumToRender not initialNumberToRender this is the first thing I have noticed that affects this issue. Still not resolved yet.

@MohamedOsman1998
Copy link

+1 this issue should be reopened

@gastonmorixe
Copy link

guys, you need to pass a data prop , either an array or your custom class and use it accordingly. data is mandatory.

@rmarimon
Copy link

rmarimon commented Jan 6, 2018

Adding data={[]} to the example seems to solve the problem.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 25, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants