From 70a3ececc368a8d0fe4b57b13ac956ad99a637c7 Mon Sep 17 00:00:00 2001 From: Eli White Date: Sat, 3 Mar 2018 15:06:43 -0800 Subject: [PATCH] Tightening type for flattenStyle Reviewed By: yungsters Differential Revision: D7131703 fbshipit-source-id: d8e37fcd0c743057e04760b1e50f8d879bd2826a --- Libraries/Animated/src/nodes/AnimatedTransform.js | 8 ++++---- Libraries/StyleSheet/flattenStyle.js | 8 +++----- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/Libraries/Animated/src/nodes/AnimatedTransform.js b/Libraries/Animated/src/nodes/AnimatedTransform.js index fd5049e9b8d8af..48f82f9fe3443d 100644 --- a/Libraries/Animated/src/nodes/AnimatedTransform.js +++ b/Libraries/Animated/src/nodes/AnimatedTransform.js @@ -15,9 +15,9 @@ const AnimatedWithChildren = require('./AnimatedWithChildren'); const NativeAnimatedHelper = require('../NativeAnimatedHelper'); class AnimatedTransform extends AnimatedWithChildren { - _transforms: Array; + _transforms: $ReadOnlyArray; - constructor(transforms: Array) { + constructor(transforms: $ReadOnlyArray) { super(); this._transforms = transforms; } @@ -34,7 +34,7 @@ class AnimatedTransform extends AnimatedWithChildren { }); } - __getValue(): Array { + __getValue(): $ReadOnlyArray { return this._transforms.map(transform => { const result = {}; for (const key in transform) { @@ -49,7 +49,7 @@ class AnimatedTransform extends AnimatedWithChildren { }); } - __getAnimatedValue(): Array { + __getAnimatedValue(): $ReadOnlyArray { return this._transforms.map(transform => { const result = {}; for (const key in transform) { diff --git a/Libraries/StyleSheet/flattenStyle.js b/Libraries/StyleSheet/flattenStyle.js index 88f839e2885ec3..21da509723294c 100644 --- a/Libraries/StyleSheet/flattenStyle.js +++ b/Libraries/StyleSheet/flattenStyle.js @@ -9,10 +9,9 @@ */ 'use strict'; -var invariant = require('fbjs/lib/invariant'); var ReactNativePropRegistry; -import type { StyleObj } from 'StyleSheetTypes'; +import type { DimensionValue, ColorValue, StyleProp, Style } from 'StyleSheetTypes'; function getStyle(style) { if (ReactNativePropRegistry === undefined) { @@ -24,11 +23,10 @@ function getStyle(style) { return style; } -function flattenStyle(style: ?StyleObj): ?Object { - if (!style) { +function flattenStyle(style: ?StyleProp>): ?Style { + if (style == null) { return undefined; } - invariant(style !== true, 'style may be false but not true'); if (!Array.isArray(style)) { /* $FlowFixMe(>=0.63.0 site=react_native_fb) This comment suppresses an