From 2749fbca9a18fdff6c3e3dd3b3c5b8086cef9cc5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Jastrze=CC=A8bski?= Date: Wed, 6 Sep 2023 15:06:46 -0700 Subject: [PATCH] fix: role="searchbox" should assing "SearchField" trait on iOS (#39314) Summary: Experimenting with Accessibility Inspector on iOS I've discovered that while when assigning `accessibilityRole="searchbox"` to a text input results in "Traits" reporting "Search Field" trait. However, when using ARIA-compatible `role="search"` such trait is not assigned, and text input will have an empty trait. Afaiu this is incorrect as using `role="search"` and `accessibilityRole="searchbox"` should equivalent effect. ## Changelog: IOS FIXED - `role="searchbox"` now assigns "Search Field" accessibility trait to a view Pull Request resolved: https://github.com/facebook/react-native/pull/39314 Test Plan: No UI changes, it affects only accessibility. Reviewed By: NickGerleman Differential Revision: D49014039 Pulled By: dmytrorykun fbshipit-source-id: 5fb194e67fbf2ac339d9a746e3ce6aaed2d32558 --- packages/react-native/React/Views/RCTViewManager.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/React/Views/RCTViewManager.m b/packages/react-native/React/Views/RCTViewManager.m index 1c57ffc0a526dd..9b4775ceec3c22 100644 --- a/packages/react-native/React/Views/RCTViewManager.m +++ b/packages/react-native/React/Views/RCTViewManager.m @@ -92,7 +92,7 @@ @implementation RCTConvert (UIAccessibilityTraits) @"scrollbar" : @(UIAccessibilityTraitNone), @"scrollview" : @(UIAccessibilityTraitNone), @"search" : @(UIAccessibilityTraitSearchField), - @"searchbox" : @(UIAccessibilityTraitNone), + @"searchbox" : @(UIAccessibilityTraitSearchField), @"selected" : @(UIAccessibilityTraitSelected), @"separator" : @(UIAccessibilityTraitNone), @"slider" : @(UIAccessibilityTraitNone),