From 1e611fd8d906b17414701ef08521203ce8659204 Mon Sep 17 00:00:00 2001
From: Nicola Corti <ncor@meta.com>
Date: Fri, 27 Sep 2024 08:40:14 -0700
Subject: [PATCH] RNGP: Read `enableWarningsAsErrors` property correctly
 (#46657)

Summary:
I've noticed that some users are reporting build failures due to warnings inside RNGP.
We do have `allWarningsAsErrors` set to true for everyone (also for users).
That's too aggressive, and can cause build failures which are not necessary. Let's keep it enabled only on our CI (when the `enableWarningsAsErrors` property is set).

## Changelog:

[INTERNAL] - RNGP: Read `enableWarningsAsErrors` property correctly

Pull Request resolved: https://github.com/facebook/react-native/pull/46657

Test Plan: CI

Reviewed By: NickGerleman

Differential Revision: D63459601

Pulled By: cortinico

fbshipit-source-id: 0307e8d6771518038a5abe27ca5a993cb0a9f8c0
---
 .../react-native-gradle-plugin/build.gradle.kts                | 3 ++-
 .../settings-plugin/build.gradle.kts                           | 3 ++-
 .../shared-testutil/build.gradle.kts                           | 3 ++-
 packages/react-native-gradle-plugin/shared/build.gradle.kts    | 3 ++-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/packages/react-native-gradle-plugin/react-native-gradle-plugin/build.gradle.kts b/packages/react-native-gradle-plugin/react-native-gradle-plugin/build.gradle.kts
index d8bcfeda9617d9..8ec00aab762a39 100644
--- a/packages/react-native-gradle-plugin/react-native-gradle-plugin/build.gradle.kts
+++ b/packages/react-native-gradle-plugin/react-native-gradle-plugin/build.gradle.kts
@@ -65,7 +65,8 @@ tasks.withType<KotlinCompile>().configureEach {
     apiVersion = "1.6"
     // See comment above on JDK 11 support
     jvmTarget = "11"
-    allWarningsAsErrors = true
+    allWarningsAsErrors =
+        project.properties["enableWarningsAsErrors"]?.toString()?.toBoolean() ?: false
   }
 }
 
diff --git a/packages/react-native-gradle-plugin/settings-plugin/build.gradle.kts b/packages/react-native-gradle-plugin/settings-plugin/build.gradle.kts
index 0db9f3e625312f..26f2c6ba85f315 100644
--- a/packages/react-native-gradle-plugin/settings-plugin/build.gradle.kts
+++ b/packages/react-native-gradle-plugin/settings-plugin/build.gradle.kts
@@ -54,7 +54,8 @@ tasks.withType<KotlinCompile>().configureEach {
     apiVersion = "1.6"
     // See comment above on JDK 11 support
     jvmTarget = "11"
-    allWarningsAsErrors = true
+    allWarningsAsErrors =
+        project.properties["enableWarningsAsErrors"]?.toString()?.toBoolean() ?: false
   }
 }
 
diff --git a/packages/react-native-gradle-plugin/shared-testutil/build.gradle.kts b/packages/react-native-gradle-plugin/shared-testutil/build.gradle.kts
index 5f447e83e6a991..2eb21810b20c8d 100644
--- a/packages/react-native-gradle-plugin/shared-testutil/build.gradle.kts
+++ b/packages/react-native-gradle-plugin/shared-testutil/build.gradle.kts
@@ -24,7 +24,8 @@ tasks.withType<KotlinCompile>().configureEach {
   kotlinOptions {
     apiVersion = "1.6"
     jvmTarget = "11"
-    allWarningsAsErrors = true
+    allWarningsAsErrors =
+        project.properties["enableWarningsAsErrors"]?.toString()?.toBoolean() ?: false
   }
 }
 
diff --git a/packages/react-native-gradle-plugin/shared/build.gradle.kts b/packages/react-native-gradle-plugin/shared/build.gradle.kts
index fa76599233ef37..a9dfa6abaa0bf4 100644
--- a/packages/react-native-gradle-plugin/shared/build.gradle.kts
+++ b/packages/react-native-gradle-plugin/shared/build.gradle.kts
@@ -29,7 +29,8 @@ tasks.withType<KotlinCompile>().configureEach {
   kotlinOptions {
     apiVersion = "1.6"
     jvmTarget = "11"
-    allWarningsAsErrors = true
+    allWarningsAsErrors =
+        project.properties["enableWarningsAsErrors"]?.toString()?.toBoolean() ?: false
   }
 }