From 36197c546db4dca07331e87157ee786038c1a0c8 Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Tue, 28 Nov 2023 17:13:32 -0800 Subject: [PATCH] Remove extraneous semicolon from mcrouter/lib/network/SecurityOptions.cpp Summary: Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them. This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function). This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers. This should be a low-risk diff: if it compiles, it works. Reviewed By: meyering Differential Revision: D51631138 fbshipit-source-id: 48112271dbb3054b3f3d60f5b81b28753a154f1b --- mcrouter/lib/network/SecurityOptions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mcrouter/lib/network/SecurityOptions.cpp b/mcrouter/lib/network/SecurityOptions.cpp index 1a6a70c6a..385ca88cc 100644 --- a/mcrouter/lib/network/SecurityOptions.cpp +++ b/mcrouter/lib/network/SecurityOptions.cpp @@ -26,7 +26,7 @@ const char* securityMechToString(SecurityMech mech) { return "fizz"; case SecurityMech::KTLS12: return "ktls12"; - }; + } folly::assume_unreachable(); }