Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/facebook-ios-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.10.1
Choose a base ref
...
head repository: facebook/facebook-ios-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.11.0
Choose a head ref
  • 20 commits
  • 25 files changed
  • 5 contributors

Commits on Nov 13, 2019

  1. optimize dot product use vdsp

    Summary: optimize convolution computation by using dot product provided by vdsp
    
    Reviewed By: dreamolight
    
    Differential Revision: D18468631
    
    fbshipit-source-id: dfe27ec17cc4300ad7afc3e8e2e2dc0a71e0f069
    ninanina0815 authored and facebook-github-bot committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    b99bfff View commit details
    Browse the repository at this point in the history
  2. enable feature by reading from cache

    Summary: When the network request fails, we should read model info from cache and check if the model file(s) exist on the device. If file(s) exist, we should enable suggested events feature.
    
    Reviewed By: dreamolight
    
    Differential Revision: D18446518
    
    fbshipit-source-id: 75aaf12c21e412444d8be37d6dc5d8aab6fc56df
    tianqibt authored and facebook-github-bot committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    cc5d33f View commit details
    Browse the repository at this point in the history
  3. add function to read rules from file

    Summary: as title
    
    Reviewed By: Oliverccccct
    
    Differential Revision: D18456659
    
    fbshipit-source-id: 928d39398d35dc15bf59051186df7b66bc1fd991
    tianqibt authored and facebook-github-bot committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    5e6a04d View commit details
    Browse the repository at this point in the history
  4. add function to return weights file path

    Summary: as title
    
    Differential Revision: D18459853
    
    fbshipit-source-id: de13865c4f26045b6eca6ff071f77233dfeee9c0
    tianqibt authored and facebook-github-bot committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    2411a00 View commit details
    Browse the repository at this point in the history
  5. make model delivery happen only once

    Summary: as title
    
    Reviewed By: Oliverccccct
    
    Differential Revision: D18487243
    
    fbshipit-source-id: c2da2a483e8730010d32d68ca3d7c58b3b63a9d0
    tianqibt authored and facebook-github-bot committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    6477726 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Migrate FeatureExtractor and EventInferencer from BetaKit to CoreKit

    Summary:
    - Migrate FeatureExtractor and EventInferencer from BetaKit to CoreKit
     - Fetch rules from FBSDKModelManager to initialize FeatureExtractor rules.
     - Remove SuggestedEventIndexer reference in FBSDKBetaKit
    
    Reviewed By: KylinChang
    
    Differential Revision: D18466824
    
    fbshipit-source-id: c13bb035a9d862ca79604ac1f41700569e3ef09f
    Tao Chen authored and facebook-github-bot committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    2a2dc28 View commit details
    Browse the repository at this point in the history
  2. Only do the prediction on the app in language "en"

    Summary: Same as the title
    
    Reviewed By: KylinChang
    
    Differential Revision: D18490780
    
    fbshipit-source-id: 3967b1a56824e634b9123f1a30cbf22b7ccc88fc
    Tao Chen authored and facebook-github-bot committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    8c19fa9 View commit details
    Browse the repository at this point in the history
  3. ignore the prediction when the event is fb_mobile_other

    Summary: Same as the title
    
    Reviewed By: KylinChang
    
    Differential Revision: D18494310
    
    fbshipit-source-id: e8f72d3ff685a97bb4e76f717dd7ccc0d723a36f
    Tao Chen authored and facebook-github-bot committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    4e753a3 View commit details
    Browse the repository at this point in the history
  4. Add check on buttonText in EventInferencer

    Summary: Same as the title
    
    Differential Revision: D18497010
    
    fbshipit-source-id: 0c9bc8e48dbbee297774ff78af5e52a6e5d61559
    Tao Chen authored and facebook-github-bot committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    8f01f93 View commit details
    Browse the repository at this point in the history
  5. do not initialize weights in initialize func

    Summary: function in initialize() won't be caught by crash report
    
    Reviewed By: tianqibt
    
    Differential Revision: D18493253
    
    fbshipit-source-id: eb6a151f1c397022735e53702443db693e4defae
    ninanina0815 authored and facebook-github-bot committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    00bb1f6 View commit details
    Browse the repository at this point in the history
  6. Fix travis build (#1114)

    Summary:
    Pull Request resolved: #1114
    
    As title
    
    Differential Revision: D18499160
    
    fbshipit-source-id: ffda736eb3889f52e9069e921a0e2cd3640b6709
    KylinChang authored and facebook-github-bot committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    1cb2e31 View commit details
    Browse the repository at this point in the history
  7. threshold comparison

    Summary: compare thresholds for predicted events
    
    Reviewed By: Oliverccccct
    
    Differential Revision: D18499305
    
    fbshipit-source-id: 1c908a73a06cb568dea07c2243cb0b20ed66f36c
    ninanina0815 authored and facebook-github-bot committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    369bbf9 View commit details
    Browse the repository at this point in the history
  8. Move text vectorization to native

    Summary: as title
    
    Reviewed By: Oliverccccct
    
    Differential Revision: D18503079
    
    fbshipit-source-id: df70992065822d499f4adce2fb2c17d083da03e2
    ninanina0815 authored and facebook-github-bot committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    a199a1b View commit details
    Browse the repository at this point in the history
  9. send report when disable feature

    Summary: We need to log which feature is disabled by crash shield and sent necessary information to our server.
    
    Reviewed By: KylinChang
    
    Differential Revision: D18500094
    
    fbshipit-source-id: 72f18c75e0a59ea48726a461c4449fd45c1eb28b
    tianqibt authored and facebook-github-bot committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    bc257df View commit details
    Browse the repository at this point in the history
  10. add model delivery and suggested events related classes to feature ma…

    …pping
    
    Summary: as title
    
    Reviewed By: YOUDAN
    
    Differential Revision: D18500347
    
    fbshipit-source-id: de39564e988eccc3948c7af0bafd8442df15d3a1
    tianqibt authored and facebook-github-bot committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    d800adc View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. CI Improvements (#1112)

    Summary:
    Pull Request resolved: #1112
    
    Updates the Swift kits release job to use carthage for building. This is convenient because it allows us to include more architecture slices with less code. See:
    #1107
    
    Also updates jazzy to take advantage of improvements to mixed Swift and ObjC projects. See:
    https://github.com/realm/jazzy/releases/tag/v0.12.0
    
    Reviewed By: jingping2015
    
    Differential Revision: D18483488
    
    fbshipit-source-id: ed989086d6b64f78b9818d0407473300537ad7e5
    joesus authored and facebook-github-bot committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    d8f5674 View commit details
    Browse the repository at this point in the history
  2. weights validation

    Summary: title
    
    Reviewed By: KylinChang
    
    Differential Revision: D18503525
    
    fbshipit-source-id: 1fe4bbb4a25b8f3d3ea70c01b632990d42285950
    ninanina0815 authored and facebook-github-bot committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    10ffed6 View commit details
    Browse the repository at this point in the history
  3. Better Implementation (#1116)

    Summary:
    Pull Request resolved: #1116
    
     - Rename the files to match FBSDK
     - Fetch rules in model manager instead of in feature extractor initialize()
     - Put Suggested Events Other into view hierarchy.
    
    Reviewed By: KylinChang
    
    Differential Revision: D18518096
    
    fbshipit-source-id: e3c69dc9a5a4dc91b8a67d9de3cd44a4b8389eb3
    Tao Chen authored and facebook-github-bot committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    31d6876 View commit details
    Browse the repository at this point in the history
  4. Bump version 5.11.0

    Summary: Bump version 5.11.0
    
    Reviewed By: tianqibt
    
    Differential Revision: D18520673
    
    fbshipit-source-id: 57f7d7ee1eb20f734a13235168ac346e4d77b7c8
    KylinChang authored and facebook-github-bot committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    0d67687 View commit details
    Browse the repository at this point in the history
  5. add check for file path

    Summary: add check for filepath just in case any function in modelmanager gets called before file path initialized.
    
    Differential Revision: D18518438
    
    fbshipit-source-id: 44be8a751b509a75c3028b573513a48cce938f84
    tianqibt authored and facebook-github-bot committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    889b0df View commit details
    Browse the repository at this point in the history
Loading