From 515cadd7feeac3b7c38550f60cdeb954dbe63477 Mon Sep 17 00:00:00 2001 From: Diego Cardoso Date: Wed, 3 Aug 2016 11:22:57 -0300 Subject: [PATCH 1/2] Added a note with instructions on eslint plugin configuration Since the only editor that I found the issue was Atom, I added just the instruction for the linter-eslint plugin. --- template/README.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/template/README.md b/template/README.md index 6275ceb34cd..87def068346 100644 --- a/template/README.md +++ b/template/README.md @@ -275,7 +275,7 @@ import 'bootstrap/dist/css/bootstrap-theme.css'; ``` import React, { Component } from 'react'; import { Navbar, Jumbotron, Button } from 'react-bootstrap'; -``` +``` Now you are ready to use the imported React Bootstrap components within your component hierarchy defined in the render method. Here is an example [App.js](https://github.com/manavsehgal/react-eshop/blob/master/src/App.js) redone using React Bootstrap. @@ -287,7 +287,10 @@ Some editors, including Sublime Text, Atom, and Visual Studio Code, provide plug They are not required for linting. You should see the linter output right in your terminal as well as the browser console. However, if you prefer the lint results to appear right in your editor, there are some extra steps you can do. -You would need to install an ESLint plugin for your editor first. +You would need to install an ESLint plugin for your editor first. + +>Note: if you are using the `linter-eslint` plugin on Atom, make sure that **Use global ESLint installation** option is checked. + Then make sure `package.json` of your project ends with this block: ```js From fe149028d914b63e114b4eb0f63f6a263e591510 Mon Sep 17 00:00:00 2001 From: Diego Cardoso Date: Wed, 3 Aug 2016 16:54:44 -0300 Subject: [PATCH 2/2] Change the format of the instructions and add screenshot. --- template/README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/template/README.md b/template/README.md index 87def068346..71eb0030cf3 100644 --- a/template/README.md +++ b/template/README.md @@ -289,7 +289,11 @@ They are not required for linting. You should see the linter output right in you You would need to install an ESLint plugin for your editor first. ->Note: if you are using the `linter-eslint` plugin on Atom, make sure that **Use global ESLint installation** option is checked. +>**A note for Atom `linter-eslint` users** + +>If you are using the Atom `linter-eslint` plugin, make sure that **Use global ESLint installation** option is checked: + +> Then make sure `package.json` of your project ends with this block: