-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint v6 was released. #7268
Comments
I may quote @ivan-aksamentov at this point:
A lot of projects make use of the npmjs.com/package/eslint-config-react-app eslint conf, as well does our project; therefore, the fix to be able to upgrade to ESLint v6 would be much appreciated. |
@ndrsllwngr this is on our radar. Once we do appropriate tests have been done we'll do the upgrade. The expectation that we upgrade within 24 hours is not reasonable. |
@ndrsllwngr as @bugzpodder said, we're working on this. With all dependencies, we need to consider breaking changes. In this case, we're worried about a change to one specific rule and are currently discussing that. Hopefully we can get this in with #7036 - as I want to merge that PR in the next few days. |
Also
I’m happy to send a PR but couldn’t find my way to the file I’d need to change… EDIT: Fixed in #7219 - ignore this comment 🤦♂ |
Yes, this was fixed @Primajin - don't worry, I also spotted it yesterday and also went "Oh, already fixed!". |
Date of release fix ? |
@bugzpodder Any update? |
@lonewarrior556 not yet. 3.0.2 should be released soon but no firm date yet. |
@mrmckeb Is it possible to just minor bump https://www.npmjs.com/package/eslint-config-react-app with the fix? And not wait on 3.0.2 of https://www.npmjs.com/package/create-react-app? It's a minor change that fixes a bug, It should be enough to unblock anyone trying to use eslint 6.0 |
Hi @lonewarrior556, we're waiting for this to be resolved... typescript-eslint/typescript-eslint#644 It's still listing v5 a the dependency. Please feel free to help push that through. |
But couldn't we just push out the change from #7219 which should be backwards compatible so both v5 and v6 users could use it? And then do everything else later in a higher version bump? |
It seems like every issue that was mentioned in here as a dependency/blocker has been resolved. Any update on the matter? |
Yes, it's resolved, but new version is not released yet, so we all are waiting for release |
Correct, I hope this will be out in the next week :) |
ESLint v6 was released yesterday. https://github.com/eslint/eslint/releases/tag/v6.0.0
Yet create-react-app has yet not released a new version, which includes the #7219 PR which fixes the #7218 issue.
Just wanted to let you know, that this fix should be released asap. As ESLint v6 is now the latest version on https://www.npmjs.com/package/eslint and a lot of people are going to experience this #7218 issue pretty soon.
The text was updated successfully, but these errors were encountered: