Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: optimize continuous integration #1308

Merged
merged 4 commits into from
Mar 25, 2019
Merged

chore: optimize continuous integration #1308

merged 4 commits into from
Mar 25, 2019

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Mar 25, 2019 •
edited
Loading

Motivation

  • Smarter CI to skip deploying v1 static website if there is no related changes.
    Example scenario:
    If we're modifying README.md, it doesn't make much sense to burden the CI to actually run the whole publish-gh-pages script
  • We already have netlify build for v1 and v2, why do we need to build static website build of v1 and v2 on our CI

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Related files have changed
image

No relevant files
image

@endiliey endiliey added the status: don't merge yet This PR is completed, but we are still waiting for other things to be ready. label Mar 25, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 25, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Mar 25, 2019 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit b26ef41

https://deploy-preview-1308--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Mar 25, 2019 •
edited
Loading

Deploy preview for docusaurus-preview ready!

Built with commit b26ef41

https://deploy-preview-1308--docusaurus-preview.netlify.com

@endiliey endiliey changed the title chore: CI should skip deploying v1 if no related changes chore: optimize continuous integration Mar 25, 2019
@endiliey endiliey merged commit 12d4ca7 into facebook:master Mar 25, 2019
@endiliey endiliey deleted the deployv1 branch March 25, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA status: don't merge yet This PR is completed, but we are still waiting for other things to be ready.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@endiliey @docusaurus-bot @facebook-github-bot