Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make currently active list filters more visible #174

Closed
merwok opened this issue Sep 27, 2022 · 4 comments · Fixed by #178
Closed

Make currently active list filters more visible #174

merwok opened this issue Sep 27, 2022 · 4 comments · Fixed by #178
Assignees
Labels
enhancement New feature or request

Comments

@merwok
Copy link
Contributor

merwok commented Sep 27, 2022

On a list page with many filters shown and the dropdown option active, admin users have a hard time finding out which filters are currently active, in order to remove one for example if the current selection has no results. They would have to go through the list and determine if the value visible is the default or not, so they end up clearing all filters (it’s the only action displayed) and re-building their selection.

Ideas:

  • A: add CSS to highlight filters with a non-default value selected

  • B: put active filters at the top of the list of filters

  • C: on top of the filter list, show currently active filters with a link to remove each: ( Age: 9+ | x ) ( Group: 10-15 | x ) (parens to represent a chip widget)

A + B or A + C are possible combinations.

I can contribute code if you agree to this feature!

@merwok merwok added the enhancement New feature or request label Sep 27, 2022
@fabiocaccamo
Copy link
Owner

fabiocaccamo commented Sep 27, 2022

This would be another nice enhancement!

  • A: I like this option, but I'm pretty sure that it's not possible to do that with CSS only.
  • B: In terms of usability it looks a little bit wrong to me ...
  • C: This would be cool, must be sure that the layouts work in different side cases (eg. values too long)

I'm for A + C, if you can contribute it would be great. 🎩

@merwok
Copy link
Contributor Author

merwok commented Sep 27, 2022

Yeah, A is custom template and CSS!

Let me make a first commit to add A (template + CSS + theme option), then work on C (no JS, custom template, if needed template tag, CSS for the chip styling, theme option)

@merwok
Copy link
Contributor Author

merwok commented Oct 6, 2022

Reopen this to add option for item C?

@fabiocaccamo
Copy link
Owner

Feature available by upgrading to 0.21.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants