From 4f4fa063fe9bb63ab1e3d1021c9dce0e8c6f54e5 Mon Sep 17 00:00:00 2001
From: Cedric van Putten <me@bycedric.com>
Date: Tue, 7 Jun 2022 18:32:16 +0200
Subject: [PATCH 1/9] [eas-cli] Add public access modifiers to classes

---
 .../eas-cli/src/metadata/apple/config/reader.ts  | 16 ++++++++--------
 .../eas-cli/src/metadata/apple/config/writer.ts  | 14 +++++++-------
 packages/eas-cli/src/metadata/apple/task.ts      |  8 ++++----
 .../src/metadata/apple/tasks/age-rating.ts       |  8 ++++----
 .../eas-cli/src/metadata/apple/tasks/app-info.ts |  8 ++++----
 .../src/metadata/apple/tasks/app-version.ts      | 10 +++++-----
 packages/eas-cli/src/metadata/errors.ts          |  6 +++---
 7 files changed, 35 insertions(+), 35 deletions(-)

diff --git a/packages/eas-cli/src/metadata/apple/config/reader.ts b/packages/eas-cli/src/metadata/apple/config/reader.ts
index 2677267304..e3693185d2 100644
--- a/packages/eas-cli/src/metadata/apple/config/reader.ts
+++ b/packages/eas-cli/src/metadata/apple/config/reader.ts
@@ -22,18 +22,18 @@ export const DEFAULT_WHATSNEW = 'Bug fixes and improved stability';
  * This uses version 0 of the config schema.
  */
 export class AppleConfigReader {
-  constructor(public readonly schema: AppleMetadata) {}
+  public constructor(public readonly schema: AppleMetadata) {}
 
-  getAgeRating(): Partial<AttributesOf<AgeRatingDeclaration>> | null {
+  public getAgeRating(): Partial<AttributesOf<AgeRatingDeclaration>> | null {
     return this.schema.advisory || null;
   }
 
-  getLocales(): string[] {
+  public getLocales(): string[] {
     // TODO: filter "default" locales, add option to add non-localized info to the config
     return unique(Object.keys(this.schema.info || {}));
   }
 
-  getInfoLocale(
+  public getInfoLocale(
     locale: string
   ): PartialExcept<AttributesOf<AppInfoLocalization>, 'locale' | 'name'> | null {
     const info = this.schema.info?.[locale];
@@ -51,7 +51,7 @@ export class AppleConfigReader {
     };
   }
 
-  getCategories(): CategoryIds | null {
+  public getCategories(): CategoryIds | null {
     if (Array.isArray(this.schema.categories) && this.schema.categories.length > 0) {
       return {
         primaryCategory: this.schema.categories[0],
@@ -63,13 +63,13 @@ export class AppleConfigReader {
   }
 
   /** Get the `AppStoreVersion` object. */
-  getVersion(): Partial<
+  public getVersion(): Partial<
     Omit<AttributesOf<AppStoreVersion>, 'releaseType' | 'earliestReleaseDate'>
   > | null {
     return this.schema.copyright ? { copyright: this.schema.copyright } : null;
   }
 
-  getVersionRelease(): Partial<
+  public getVersionRelease(): Partial<
     Pick<AttributesOf<AppStoreVersion>, 'releaseType' | 'earliestReleaseDate'>
   > | null {
     const { release } = this.schema;
@@ -99,7 +99,7 @@ export class AppleConfigReader {
     return null;
   }
 
-  getVersionLocale(
+  public getVersionLocale(
     locale: string,
     context: { versionIsFirst: boolean }
   ): Partial<AttributesOf<AppStoreVersionLocalization>> | null {
diff --git a/packages/eas-cli/src/metadata/apple/config/writer.ts b/packages/eas-cli/src/metadata/apple/config/writer.ts
index 95566af1e0..69e48411b6 100644
--- a/packages/eas-cli/src/metadata/apple/config/writer.ts
+++ b/packages/eas-cli/src/metadata/apple/config/writer.ts
@@ -18,18 +18,18 @@ export class AppleConfigWriter {
   constructor(public readonly schema: Partial<AppleMetadata> = {}) {}
 
   /** Get the schema result to write it to the config file */
-  toSchema(): { configVersion: number; apple: Partial<AppleMetadata> } {
+  public toSchema(): { configVersion: number; apple: Partial<AppleMetadata> } {
     return {
       configVersion: 0,
       apple: this.schema,
     };
   }
 
-  setAgeRating(attributes: AttributesOf<AgeRatingDeclaration>): void {
+  public setAgeRating(attributes: AttributesOf<AgeRatingDeclaration>): void {
     this.schema.advisory = attributes;
   }
 
-  setInfoLocale(attributes: AttributesOf<AppInfoLocalization>): void {
+  public setInfoLocale(attributes: AttributesOf<AppInfoLocalization>): void {
     this.schema.info = this.schema.info ?? {};
     const existing = this.schema.info[attributes.locale] ?? {};
 
@@ -43,7 +43,7 @@ export class AppleConfigWriter {
     };
   }
 
-  setCategories({ primaryCategory, secondaryCategory }: AttributesOf<AppInfo>): void {
+  public setCategories({ primaryCategory, secondaryCategory }: AttributesOf<AppInfo>): void {
     this.schema.categories = [];
 
     // TODO: see why these types are conflicting
@@ -55,13 +55,13 @@ export class AppleConfigWriter {
     }
   }
 
-  setVersion(
+  public setVersion(
     attributes: Omit<AttributesOf<AppStoreVersion>, 'releaseType' | 'earliestReleaseDate'>
   ): void {
     this.schema.copyright = optional(attributes.copyright);
   }
 
-  setVersionRelease(
+  public setVersionRelease(
     attributes: Pick<AttributesOf<AppStoreVersion>, 'releaseType' | 'earliestReleaseDate'>
   ): void {
     if (attributes.releaseType === ReleaseType.SCHEDULED) {
@@ -83,7 +83,7 @@ export class AppleConfigWriter {
     }
   }
 
-  setVersionLocale(attributes: AttributesOf<AppStoreVersionLocalization>): void {
+  public setVersionLocale(attributes: AttributesOf<AppStoreVersionLocalization>): void {
     this.schema.info = this.schema.info ?? {};
     const existing = this.schema.info[attributes.locale] ?? {};
 
diff --git a/packages/eas-cli/src/metadata/apple/task.ts b/packages/eas-cli/src/metadata/apple/task.ts
index 037ab9cc55..9f7c1f0265 100644
--- a/packages/eas-cli/src/metadata/apple/task.ts
+++ b/packages/eas-cli/src/metadata/apple/task.ts
@@ -4,16 +4,16 @@ import { AppleData, PartialAppleData } from './data';
 
 export abstract class AppleTask {
   /** Get a description from the task to use as section headings in the log */
-  abstract name(): string;
+  public abstract name(): string;
 
   /** Prepare the data from the App Store to start syncing with the store configuration */
-  abstract prepareAsync(options: TaskPrepareOptions): Promise<void>;
+  public abstract prepareAsync(options: TaskPrepareOptions): Promise<void>;
 
   /** Download all information from the App Store to generate the store configuration */
-  abstract downloadAsync(options: TaskDownloadOptions): Promise<void>;
+  public abstract downloadAsync(options: TaskDownloadOptions): Promise<void>;
 
   /** Upload all information from the store configuration to the App Store */
-  abstract uploadAsync(options: TaskUploadOptions): Promise<void>;
+  public abstract uploadAsync(options: TaskUploadOptions): Promise<void>;
 }
 
 export type TaskPrepareOptions = {
diff --git a/packages/eas-cli/src/metadata/apple/tasks/age-rating.ts b/packages/eas-cli/src/metadata/apple/tasks/age-rating.ts
index 6cb6319d4e..32fd755174 100644
--- a/packages/eas-cli/src/metadata/apple/tasks/age-rating.ts
+++ b/packages/eas-cli/src/metadata/apple/tasks/age-rating.ts
@@ -12,20 +12,20 @@ export type AgeRatingData = {
 };
 
 export class AgeRatingTask extends AppleTask {
-  name = (): string => 'age rating declarations';
+  public name = (): string => 'age rating declarations';
 
-  async prepareAsync({ context }: TaskPrepareOptions): Promise<void> {
+  public async prepareAsync({ context }: TaskPrepareOptions): Promise<void> {
     assert(context.version, `App version information is not prepared, can't update age rating`);
     context.ageRating = (await context.version.getAgeRatingDeclarationAsync()) || undefined;
   }
 
-  async downloadAsync({ config, context }: TaskDownloadOptions): Promise<void> {
+  public async downloadAsync({ config, context }: TaskDownloadOptions): Promise<void> {
     if (context.ageRating) {
       config.setAgeRating(context.ageRating.attributes);
     }
   }
 
-  async uploadAsync({ config, context }: TaskUploadOptions): Promise<void> {
+  public async uploadAsync({ config, context }: TaskUploadOptions): Promise<void> {
     assert(context.ageRating, `Age rating not initialized, can't update age rating`);
 
     const ageRating = config.getAgeRating();
diff --git a/packages/eas-cli/src/metadata/apple/tasks/app-info.ts b/packages/eas-cli/src/metadata/apple/tasks/app-info.ts
index aaa49d43e3..c4ba6cbd9c 100644
--- a/packages/eas-cli/src/metadata/apple/tasks/app-info.ts
+++ b/packages/eas-cli/src/metadata/apple/tasks/app-info.ts
@@ -15,9 +15,9 @@ export type AppInfoData = {
 };
 
 export class AppInfoTask extends AppleTask {
-  name = (): string => 'app information';
+  public name = (): string => 'app information';
 
-  async prepareAsync({ context }: TaskPrepareOptions): Promise<void> {
+  public async prepareAsync({ context }: TaskPrepareOptions): Promise<void> {
     const info = await retryIfNullAsync(() => context.app.getEditAppInfoAsync());
     assert(info, 'Could not resolve the editable app info to update');
 
@@ -25,7 +25,7 @@ export class AppInfoTask extends AppleTask {
     context.infoLocales = await info.getLocalizationsAsync();
   }
 
-  async downloadAsync({ config, context }: TaskDownloadOptions): Promise<void> {
+  public async downloadAsync({ config, context }: TaskDownloadOptions): Promise<void> {
     assert(context.info, `App info not initialized, can't download info`);
 
     config.setCategories(context.info.attributes);
@@ -35,7 +35,7 @@ export class AppInfoTask extends AppleTask {
     }
   }
 
-  async uploadAsync({ config, context }: TaskUploadOptions): Promise<void> {
+  public async uploadAsync({ config, context }: TaskUploadOptions): Promise<void> {
     assert(context.info, `App info not initialized, can't update info`);
 
     const categories = config.getCategories();
diff --git a/packages/eas-cli/src/metadata/apple/tasks/app-version.ts b/packages/eas-cli/src/metadata/apple/tasks/app-version.ts
index f8e862eccc..0997b35e93 100644
--- a/packages/eas-cli/src/metadata/apple/tasks/app-version.ts
+++ b/packages/eas-cli/src/metadata/apple/tasks/app-version.ts
@@ -28,7 +28,7 @@ export type AppVersionData = {
 export class AppVersionTask extends AppleTask {
   private options: AppVersionOptions;
 
-  constructor(options: Partial<AppVersionOptions> = {}) {
+  public constructor(options: Partial<AppVersionOptions> = {}) {
     super();
     this.options = {
       platform: options.platform || Platform.IOS,
@@ -36,9 +36,9 @@ export class AppVersionTask extends AppleTask {
     };
   }
 
-  name = (): string => (this.options.editLive ? 'live app version' : 'editable app version');
+  public name = (): string => (this.options.editLive ? 'live app version' : 'editable app version');
 
-  async prepareAsync({ context }: TaskPrepareOptions): Promise<void> {
+  public async prepareAsync({ context }: TaskPrepareOptions): Promise<void> {
     const { version, versionIsFirst, versionIsLive } = await resolveVersionAsync(
       context.app,
       this.options
@@ -52,7 +52,7 @@ export class AppVersionTask extends AppleTask {
     context.versionLocales = await version.getLocalizationsAsync();
   }
 
-  async downloadAsync({ config, context }: TaskDownloadOptions): Promise<void> {
+  public async downloadAsync({ config, context }: TaskDownloadOptions): Promise<void> {
     assert(context.version, `App version not initialized, can't download version`);
 
     config.setVersion(context.version.attributes);
@@ -63,7 +63,7 @@ export class AppVersionTask extends AppleTask {
     }
   }
 
-  async uploadAsync({ config, context }: TaskUploadOptions): Promise<void> {
+  public async uploadAsync({ config, context }: TaskUploadOptions): Promise<void> {
     assert(context.version, `App version not initialized, can't update version`);
 
     const version = config.getVersion();
diff --git a/packages/eas-cli/src/metadata/errors.ts b/packages/eas-cli/src/metadata/errors.ts
index 6142d96b2f..a4f5bc2465 100644
--- a/packages/eas-cli/src/metadata/errors.ts
+++ b/packages/eas-cli/src/metadata/errors.ts
@@ -8,7 +8,7 @@ import Log, { link } from '../log';
  * and should contain useful information for the user to solve before trying again.
  */
 export class MetadataValidationError extends Error {
-  constructor(message?: string, public readonly errors?: ErrorObject[]) {
+  public constructor(message?: string, public readonly errors?: ErrorObject[]) {
     super(message ?? 'Store configuration validation failed');
   }
 }
@@ -20,7 +20,7 @@ export class MetadataValidationError extends Error {
  * It contains that list of encountered errors to present to the user.
  */
 export class MetadataUploadError extends Error {
-  constructor(public readonly errors: Error[], public readonly executionId: string) {
+  public constructor(public readonly errors: Error[], public readonly executionId: string) {
     super(
       `Store configuration upload encountered ${
         errors.length === 1 ? 'an error' : `${errors.length} errors`
@@ -36,7 +36,7 @@ export class MetadataUploadError extends Error {
  * It contains that list of encountered errors to present to the user.
  */
 export class MetadataDownloadError extends Error {
-  constructor(public readonly errors: Error[], public readonly executionId: string) {
+  public constructor(public readonly errors: Error[], public readonly executionId: string) {
     super(
       `Store configuration download encountered ${
         errors.length === 1 ? 'an error' : `${errors.length} errors`

From 052f40d48e3d1cbe69162507e02532c6e7b154ff Mon Sep 17 00:00:00 2001
From: Cedric van Putten <me@bycedric.com>
Date: Tue, 7 Jun 2022 18:38:38 +0200
Subject: [PATCH 2/9] [eas-cli] Add specific types to date precision remover

---
 packages/eas-cli/src/metadata/utils/date.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/eas-cli/src/metadata/utils/date.ts b/packages/eas-cli/src/metadata/utils/date.ts
index 7ac64b9719..f3ff11f824 100644
--- a/packages/eas-cli/src/metadata/utils/date.ts
+++ b/packages/eas-cli/src/metadata/utils/date.ts
@@ -9,7 +9,7 @@
  *   "pointer": "/data/attributes/earliestReleaseDate"
  * }
  */
-export function removeDatePrecision(date: any): null | Date {
+export function removeDatePrecision(date: string | number | Date): null | Date {
   if (date) {
     try {
       const result = new Date(date);

From a22074fec180ee73f2926ce181ad08d4760adda4 Mon Sep 17 00:00:00 2001
From: Cedric van Putten <me@bycedric.com>
Date: Tue, 7 Jun 2022 19:01:52 +0200
Subject: [PATCH 3/9] [eas-cli] Add try catch around writing json to always
 unsubscribe

---
 packages/eas-cli/src/metadata/download.ts | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/packages/eas-cli/src/metadata/download.ts b/packages/eas-cli/src/metadata/download.ts
index 70e7441afe..88e59b9384 100644
--- a/packages/eas-cli/src/metadata/download.ts
+++ b/packages/eas-cli/src/metadata/download.ts
@@ -54,8 +54,13 @@ export async function downloadMetadataAsync(metadataCtx: MetadataContext): Promi
     }
   }
 
-  await fs.writeJson(filePath, config.toSchema(), { spaces: 2 });
-  unsubscribeTelemetry();
+  try {
+    await fs.writeJson(filePath, config.toSchema(), { spaces: 2 });
+  } catch (error) {
+    throw error;
+  } finally {
+    unsubscribeTelemetry();
+  }
 
   if (errors.length > 0) {
     throw new MetadataDownloadError(errors, executionId);

From 38dd00caf12db0bc1a9f2d2ded827bde1fd5a444 Mon Sep 17 00:00:00 2001
From: Cedric van Putten <me@bycedric.com>
Date: Tue, 7 Jun 2022 19:10:24 +0200
Subject: [PATCH 4/9] [eas-cli] Add async return await to uploadAsync log
 methods

---
 packages/eas-cli/src/metadata/apple/tasks/app-info.ts    | 9 +++++----
 packages/eas-cli/src/metadata/apple/tasks/app-version.ts | 9 +++++----
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/packages/eas-cli/src/metadata/apple/tasks/app-info.ts b/packages/eas-cli/src/metadata/apple/tasks/app-info.ts
index c4ba6cbd9c..fc9e798393 100644
--- a/packages/eas-cli/src/metadata/apple/tasks/app-info.ts
+++ b/packages/eas-cli/src/metadata/apple/tasks/app-info.ts
@@ -68,10 +68,11 @@ export class AppInfoTask extends AppleTask {
 
         const model = context.infoLocales.find(model => model.attributes.locale === locale);
         await logAsync(
-          () =>
-            model
-              ? model.updateAsync(attributes)
-              : context.info.createLocalizationAsync({ ...attributes, locale }),
+          async () => {
+            return model
+              ? await model.updateAsync(attributes)
+              : await context.info.createLocalizationAsync({ ...attributes, locale });
+          },
           {
             pending: `${model ? 'Updating' : 'Creating'} localized info for ${locale}...`,
             success: `${model ? 'Updated' : 'Created'} localized info for ${locale}`,
diff --git a/packages/eas-cli/src/metadata/apple/tasks/app-version.ts b/packages/eas-cli/src/metadata/apple/tasks/app-version.ts
index 0997b35e93..54d7bcc771 100644
--- a/packages/eas-cli/src/metadata/apple/tasks/app-version.ts
+++ b/packages/eas-cli/src/metadata/apple/tasks/app-version.ts
@@ -97,10 +97,11 @@ export class AppVersionTask extends AppleTask {
 
         const oldModel = context.versionLocales.find(model => model.attributes.locale === locale);
         await logAsync(
-          () =>
-            oldModel
-              ? oldModel.updateAsync(attributes)
-              : context.version.createLocalizationAsync({ ...attributes, locale }),
+          async () => {
+            return oldModel
+              ? await oldModel.updateAsync(attributes)
+              : await context.version.createLocalizationAsync({ ...attributes, locale });
+          },
           {
             pending: `${oldModel ? 'Updating' : 'Creating'} localized version for ${locale}...`,
             success: `${oldModel ? 'Updated' : 'Created'} localized version for ${locale}`,

From 4b53623931190b922aee0dc9b59e9d4532a6b4fe Mon Sep 17 00:00:00 2001
From: Cedric van Putten <me@bycedric.com>
Date: Wed, 8 Jun 2022 08:40:29 +0200
Subject: [PATCH 5/9] [eas-cli] Fix date precision type and test

---
 packages/eas-cli/src/metadata/utils/__tests__/date.test.ts | 1 -
 packages/eas-cli/src/metadata/utils/date.ts                | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/packages/eas-cli/src/metadata/utils/__tests__/date.test.ts b/packages/eas-cli/src/metadata/utils/__tests__/date.test.ts
index a08779429b..03e32a4ca6 100644
--- a/packages/eas-cli/src/metadata/utils/__tests__/date.test.ts
+++ b/packages/eas-cli/src/metadata/utils/__tests__/date.test.ts
@@ -4,7 +4,6 @@ describe(removeDatePrecision, () => {
   it('returns null for falsy values', () => {
     expect(removeDatePrecision(null)).toBeNull();
     expect(removeDatePrecision(undefined)).toBeNull();
-    expect(removeDatePrecision(false)).toBeNull();
   });
 
   it('returns null for invalid dates', () => {
diff --git a/packages/eas-cli/src/metadata/utils/date.ts b/packages/eas-cli/src/metadata/utils/date.ts
index f3ff11f824..28f427518b 100644
--- a/packages/eas-cli/src/metadata/utils/date.ts
+++ b/packages/eas-cli/src/metadata/utils/date.ts
@@ -9,7 +9,7 @@
  *   "pointer": "/data/attributes/earliestReleaseDate"
  * }
  */
-export function removeDatePrecision(date: string | number | Date): null | Date {
+export function removeDatePrecision(date: null | undefined | string | number | Date): null | Date {
   if (date) {
     try {
       const result = new Date(date);

From fb7021bd616066dee79e0355dfd724300db1c5c5 Mon Sep 17 00:00:00 2001
From: Cedric van Putten <me@bycedric.com>
Date: Wed, 8 Jun 2022 09:00:23 +0200
Subject: [PATCH 6/9] [eas-cli] Use submission profile bundle id if defined

---
 packages/eas-cli/src/metadata/context.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/eas-cli/src/metadata/context.ts b/packages/eas-cli/src/metadata/context.ts
index 161d47c9c7..63a518de3a 100644
--- a/packages/eas-cli/src/metadata/context.ts
+++ b/packages/eas-cli/src/metadata/context.ts
@@ -64,7 +64,9 @@ export async function createMetadataContextAsync(params: {
 
   const exp = params.exp ?? getExpoConfig(params.projectDir);
   const user = await ensureLoggedInAsync();
-  const bundleIdentifier = await getBundleIdentifierAsync(params.projectDir, exp);
+  const bundleIdentifier =
+    iosSubmissionProfile.bundleIdentifier ??
+    (await getBundleIdentifierAsync(params.projectDir, exp));
 
   return {
     platform: Platform.IOS,

From 8e2dc55fec442fc2c614b21f14b8ec0126a57859 Mon Sep 17 00:00:00 2001
From: Cedric van Putten <me@bycedric.com>
Date: Wed, 8 Jun 2022 11:36:23 +0200
Subject: [PATCH 7/9] [eas-cli] Drop catch from IO try catch block

---
 packages/eas-cli/src/metadata/download.ts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/packages/eas-cli/src/metadata/download.ts b/packages/eas-cli/src/metadata/download.ts
index 88e59b9384..2f607f8bef 100644
--- a/packages/eas-cli/src/metadata/download.ts
+++ b/packages/eas-cli/src/metadata/download.ts
@@ -56,8 +56,6 @@ export async function downloadMetadataAsync(metadataCtx: MetadataContext): Promi
 
   try {
     await fs.writeJson(filePath, config.toSchema(), { spaces: 2 });
-  } catch (error) {
-    throw error;
   } finally {
     unsubscribeTelemetry();
   }

From 13c61fe6bffa7809661363833aa54200536a71ba Mon Sep 17 00:00:00 2001
From: Cedric van Putten <me@bycedric.com>
Date: Wed, 8 Jun 2022 11:44:27 +0200
Subject: [PATCH 8/9] [eas-cli] Move unique helper to global utils

---
 .../eas-cli/src/metadata/apple/config/reader.ts   |  4 ++--
 packages/eas-cli/src/metadata/utils/array.ts      |  4 ----
 .../src/utils/expodash/__tests__/uniq-test.ts     | 15 +++++++++++++++
 packages/eas-cli/src/utils/expodash/uniq.ts       |  4 ++++
 4 files changed, 21 insertions(+), 6 deletions(-)
 delete mode 100644 packages/eas-cli/src/metadata/utils/array.ts
 create mode 100644 packages/eas-cli/src/utils/expodash/__tests__/uniq-test.ts
 create mode 100644 packages/eas-cli/src/utils/expodash/uniq.ts

diff --git a/packages/eas-cli/src/metadata/apple/config/reader.ts b/packages/eas-cli/src/metadata/apple/config/reader.ts
index e3693185d2..a19ee99eb9 100644
--- a/packages/eas-cli/src/metadata/apple/config/reader.ts
+++ b/packages/eas-cli/src/metadata/apple/config/reader.ts
@@ -7,7 +7,7 @@ import {
   ReleaseType,
 } from '@expo/apple-utils';
 
-import { unique } from '../../utils/array';
+import uniq from '../../../utils/expodash/uniq';
 import { AttributesOf } from '../../utils/asc';
 import { removeDatePrecision } from '../../utils/date';
 import { AppleMetadata } from '../types';
@@ -30,7 +30,7 @@ export class AppleConfigReader {
 
   public getLocales(): string[] {
     // TODO: filter "default" locales, add option to add non-localized info to the config
-    return unique(Object.keys(this.schema.info || {}));
+    return uniq(Object.keys(this.schema.info || {}));
   }
 
   public getInfoLocale(
diff --git a/packages/eas-cli/src/metadata/utils/array.ts b/packages/eas-cli/src/metadata/utils/array.ts
deleted file mode 100644
index ab00e45a3c..0000000000
--- a/packages/eas-cli/src/metadata/utils/array.ts
+++ /dev/null
@@ -1,4 +0,0 @@
-export function unique<T = any>(items: T[]): T[] {
-  const set = new Set(items);
-  return [...set];
-}
diff --git a/packages/eas-cli/src/utils/expodash/__tests__/uniq-test.ts b/packages/eas-cli/src/utils/expodash/__tests__/uniq-test.ts
new file mode 100644
index 0000000000..eb3e6de63f
--- /dev/null
+++ b/packages/eas-cli/src/utils/expodash/__tests__/uniq-test.ts
@@ -0,0 +1,15 @@
+import uniq from '../uniq';
+
+describe(uniq, () => {
+  it('returns unique numbers from a list', () => {
+    expect(uniq([1, 2, 2, 3, 4, 2, 3])).toEqual([1, 2, 3, 4]);
+  });
+
+  it('returns unique strings from a list', () => {
+    expect(uniq(['hi', 'hello', 'hello', 'ola'])).toEqual(['hi', 'hello', 'ola']);
+  });
+
+  it('returns unique mixed types from a list', () => {
+    expect(uniq([1, 2, 2, 'hi', 'hi', 'hello', 3])).toEqual([1, 2, 'hi', 'hello', 3]);
+  });
+});
diff --git a/packages/eas-cli/src/utils/expodash/uniq.ts b/packages/eas-cli/src/utils/expodash/uniq.ts
new file mode 100644
index 0000000000..8f8b093cba
--- /dev/null
+++ b/packages/eas-cli/src/utils/expodash/uniq.ts
@@ -0,0 +1,4 @@
+export default function uniq<T = any>(items: T[]): T[] {
+  const set = new Set(items);
+  return [...set];
+}

From e486f179595be573bc98d239f47fb51949eb2f13 Mon Sep 17 00:00:00 2001
From: Cedric van Putten <me@bycedric.com>
Date: Mon, 13 Jun 2022 13:55:30 +0200
Subject: [PATCH 9/9] [eas-cli] Prefer nullish coalescing

---
 packages/eas-cli/src/metadata/apple/config/reader.ts     | 2 +-
 packages/eas-cli/src/metadata/apple/tasks/app-version.ts | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/eas-cli/src/metadata/apple/config/reader.ts b/packages/eas-cli/src/metadata/apple/config/reader.ts
index a19ee99eb9..07ee59b9d4 100644
--- a/packages/eas-cli/src/metadata/apple/config/reader.ts
+++ b/packages/eas-cli/src/metadata/apple/config/reader.ts
@@ -43,7 +43,7 @@ export class AppleConfigReader {
 
     return {
       locale,
-      name: info.title || 'no name provided',
+      name: info.title ?? 'no name provided',
       subtitle: info.subtitle,
       privacyChoicesUrl: info.privacyChoicesUrl,
       privacyPolicyText: info.privacyPolicyText,
diff --git a/packages/eas-cli/src/metadata/apple/tasks/app-version.ts b/packages/eas-cli/src/metadata/apple/tasks/app-version.ts
index 54d7bcc771..117bff20d8 100644
--- a/packages/eas-cli/src/metadata/apple/tasks/app-version.ts
+++ b/packages/eas-cli/src/metadata/apple/tasks/app-version.ts
@@ -31,8 +31,8 @@ export class AppVersionTask extends AppleTask {
   public constructor(options: Partial<AppVersionOptions> = {}) {
     super();
     this.options = {
-      platform: options.platform || Platform.IOS,
-      editLive: options.editLive || false,
+      platform: options.platform ?? Platform.IOS,
+      editLive: options.editLive ?? false,
     };
   }