Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and improve Windows support #13

Closed
anp opened this issue Jan 16, 2017 · 3 comments
Closed

Test and improve Windows support #13

anp opened this issue Jan 16, 2017 · 3 comments

Comments

@anp
Copy link
Contributor

anp commented Jan 16, 2017

In theory, everything has been set up to work cross platform, but I haven't run it on Windows yet and support may be flaky or problematic.

Using AppVeyor or something similar would probably be good too (cc #2).

@anp
Copy link
Contributor Author

anp commented Jan 16, 2017

yarnpkg/yarn#2192 may be concerning.

@anp
Copy link
Contributor Author

anp commented Feb 8, 2017

Getting the installation working on windows has required some fixes in xdl (expo/xdl@6d9ebdc , expo/xdl@f9945f5 , expo/xdl@59e4223), but once these are published to npm it will at least be installable.

TODO: add message about alpha-level windows support to readme.

@anp
Copy link
Contributor Author

anp commented Feb 24, 2017

Notes from my recent round of testing on Windows (w/ node 6.9):

  • create-react-native-app install is fine without anything but node
  • yarnpkg is not recognized as an internal or external command... <-- this should probably be suppressed until we are sure that yarn is installed (probably repros on other OSes) (Suppress yarnpkg is not a command when only npm is installed #39)
  • without build tools installed, there are a lot of gyp ERRs that print, but they're only for optional dependencies and don't affect any CRNA functionality
    • not sure there's anything that can be done about this except running in quiet mode, which would suppress important output.
  • react-native-scripts currently has a git devDependency, which is not installed on many windows machines to start. need to either publish as a scoped package, put a tarball somewhere, require a git install from users, or rewrite my build scripts to not use gulp 4.
  • template project has \n line endings, but notepad and some other tools will expect \r\n line endings. most editors should be able to handle this, but it might cause some issues.
  • eject to ExponentKit asks for an ios bundle identifier on Windows even though the underlying xdl call will refuse to build an iOS project
  • ExponentKit eject is currently not working on windows, @jesseruder is currently investigating.
  • exponent-sdk has two git dependencies: https://github.com/exponent/exponent-sdk/blob/master/package.json#L32-L33 -- discussing with exponent folks about how to handle

@anp anp closed this as completed Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant