Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary-search-tree: implement exercise #740

Closed
ilya-khadykin opened this issue Oct 6, 2017 · 8 comments
Closed

binary-search-tree: implement exercise #740

ilya-khadykin opened this issue Oct 6, 2017 · 8 comments

Comments

@ilya-khadykin
Copy link
Contributor

There are exercises that are not yet implemented in Python track (the full list of them - #417 (comment)).
You can help us change this situation by implementing this one. Ref #417

The guide "Implement an exercise from specification" will help you succeed.

If you still have questions, I encourage you to ask them before starting working on the issue.

I also suggest claiming the issue by creating an empty PR as stated here

Please note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
This simple thing helps us a lot, and makes our life a bit easier

@ilya-khadykin ilya-khadykin changed the title binary-search-tree #388: implement exercise binary-search-tree: implement exercise Oct 6, 2017
@ilya-khadykin
Copy link
Contributor Author

#388 can be useful

@rodrigocam
Copy link
Contributor

I'm working on it!

@ilya-khadykin
Copy link
Contributor Author

@ilya-khadykin
Copy link
Contributor Author

@rodrigocam ah, I see, you've done that, but forgot to add a reference to this issue in order to add visibility. I strongly recommend always doing it, it saves a lot of time.

Please also note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
It makes our work much easier. I hope this hint will help you to make your future PRs a bit better

@rodrigocam
Copy link
Contributor

Alright, thanks! Which methods do you want in the binary search tree? I create an insert method and preorder, inorder and postorder traversals.

@rodrigocam
Copy link
Contributor

I made a pull request with the implementation, please take a look!

@ilya-khadykin
Copy link
Contributor Author

ilya-khadykin commented Oct 9, 2017

@rodrigocam thanks! You've created two PRs #773 and #768. Could you please close one to avoid confusion.

Which methods do you want in the binary search tree?

It's up to you

@rodrigocam
Copy link
Contributor

Ok, sorry. I closed one of them, please take a look (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants