Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sum-of-multiples: add parameters to exercise placeholder #644

Closed
ilya-khadykin opened this issue Oct 3, 2017 · 3 comments
Closed

sum-of-multiples: add parameters to exercise placeholder #644

ilya-khadykin opened this issue Oct 3, 2017 · 3 comments

Comments

@ilya-khadykin
Copy link
Contributor

We would like you to help us add expected parameters in placeholder templates as described in #509 to make it easier for learners to start working on the exercise in question.

Feel free to ask any questions, we'll be glad to help!
@mikeyny mikeyny mentioned this issue Oct 3, 2017
Closed
@ackerleytng ackerleytng mentioned this issue Oct 9, 2017
Merged
@ackerleytng
Copy link
Contributor

Hi! This is my first pull request ever! I'm trying to understand how pull requests work...

I've completed all the necessary edits and pushed to my sum-of-multiples-add-parameters branch at ackerleytng/python.

Do I have to make another pull request after this push, or is this good enough?

@ilya-khadykin
Copy link
Contributor Author

@ackerleytng no, it looks Ok. I merged it btw 😄

@ackerleytng
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ackerleytng @ilya-khadykin