-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyData theme CSS resulted in unexpected changes to this theme's style #765
Comments
I also wouldn't mind disabling the "Back to top" button spawning in the bottom half of the screen, at lease when you're not on a phone. It's not strictly related to the theme color issue, but I don't want to spam the tracker. |
A lot of these were inherited from the PyData Sphinx Theme, which made these updates to improve the accessibility of the theme in general. I don't think we should revert changes that we know improve accessibility (e.g. color contrast) just because we think they don't look as good, but if we can identify improvements that are equally as accessible, then I'm fine implementing them here. |
With the font color remaining stark white, since turning the background from pitch black to dark blue decreases the contrast between them, I don't understand how it improves accessibility, For the "back to top" button, I doubt that's related to accessibility (but I don't think you were saying that). |
I just added some changes to address some of these in #775 - can you take a look there? I think it'll be more productive to make some minor adjustments to this theme rather than to re-litigate the long accessibility discussions that happened already in the pydata theme |
Recent changes to the style have made the dark theme's background bluish instead of dark grey, and the hovered links purple instead of blue.
The preceding style was much better so I believe that change should be reverted, or at least an option provided to opt-out and go back to the former colors.
Former :


New :
The text was updated successfully, but these errors were encountered: