Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic links inside in/out directory not working #35

Closed
tomuben opened this issue Jun 8, 2021 · 0 comments
Closed

Symbolic links inside in/out directory not working #35

tomuben opened this issue Jun 8, 2021 · 0 comments
Labels
feature Product feature shelved:yes Closed because this ticket is very unlikely to get implemented

Comments

@tomuben
Copy link
Collaborator

tomuben commented Jun 8, 2021

Background

In #10 we add volume mount points for each directory given by the arguments.
However, if any of the directories contain symbolic links to paths which are not mounted, the container won't have access to those directories which might cause the respective docker run to fail.

For example assume the following scenario
$HOME
├── flavors
│   └── my_flavor
│   └── flavor_base
│   └── build_deps -> ../../../my_deps/
└── my_deps

running

./exaslct export --flavor-path=flavors/my_flavor --export-path ./out

will not work, as $HOME/my_deps will not be visible from within the container.

Acceptance Criteria

In starter_scripts/exaslct_within_docker_container.sh find all symbolic links of all mount point directories (given by command line arguments) and add to this list. As this might be very expansive, declare a new command line parameter --mount_symbolic_link_directories which enable/disables this functionality.

Alternative:

Add a command line parameter --mount-extra-directory which allows the user to specify additional directories which get mounted to the container. This would also solve problems with get_additional_build_directories_mapping configration in the flavors which in theory could point anywhere in the file system.

@tomuben tomuben added source:exasol bug Unwanted / harmful behavior labels Jun 8, 2021
@tkilias tkilias added feature Product feature and removed bug Unwanted / harmful behavior labels Aug 26, 2021
@tkilias tkilias added the timeline:long-term Unlikely to be implemented in the near future label Nov 12, 2021
@redcatbear redcatbear added shelved:yes Closed because this ticket is very unlikely to get implemented and removed timeline:long-term Unlikely to be implemented in the near future labels Apr 13, 2023
@redcatbear redcatbear closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product feature shelved:yes Closed because this ticket is very unlikely to get implemented
Projects
None yet
Development

No branches or pull requests

3 participants