Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_logs inner method find_tags does not work when there is a log file present. #176

Open
lupeterm opened this issue Jan 14, 2024 · 0 comments · May be fixed by #165
Open

find_logs inner method find_tags does not work when there is a log file present. #176

lupeterm opened this issue Jan 14, 2024 · 0 comments · May be fixed by #165
Labels
bug Something isn't working

Comments

@lupeterm
Copy link
Collaborator

lupeterm commented Jan 14, 2024

Example:

└── fd52708db5c296d1fa52b056701be4ee
        ├── signac_job_document_6850e48aa71863aac82ca3c2cdd6d5e2_test_campaign.json
        ├── signac_job_document.json
        ├── signac_statepoint.json
        └── test_campaign
            ├── decomposePar_2024-01-05_17:38:44.log
            ├── instrumentedPimpleFoam_2024-01-05_17:44:32.log
            ├── solverExitCode.log
            └── test_tag
                ├── decomposePar_2024-01-05_17:38:44.log
                ├── instrumentedPimpleFoam_2024-01-05_17:44:32.log
                └── solverExitCode.log

How to reproduce:

  1. Call obr archive without specifying a tag
  2. Call obr apply
  3. Call obr archive with specifying a tag
  4. Call obr apply

Now, the folder structure will look like the above and the inner function find_tags will enter the first branch, setting tag_mapping[str(path)] = [] as the default value of tagsis the empty list. This results in the tags being ignored.

@lupeterm lupeterm added the bug Something isn't working label Jan 14, 2024
@lupeterm lupeterm linked a pull request Jan 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant