Feat/poisson equation #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* operatorMixin did not copy the coeffs * change API of lapacianOperatorFactory and update the operators * change API of divOperatorFactory and update the operators
|
Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_267 |
greole
reviewed
Feb 26, 2025
Comment on lines
+22
to
24
| << "key requested: " << key << "requested type " << demangle(typeid(T).name()) << "\n" | ||
| << "actual type " << demangle(data.at(key).type().name()) << "\n" | ||
| << e.what() << std::endl; |
There was a problem hiding this comment.
would https://en.cppreference.com/w/cpp/utility/format/format work? Could look like (not tested):
Suggested change
| << "key requested: " << key << "requested type " << demangle(typeid(T).name()) << "\n" | |
| << "actual type " << demangle(data.at(key).type().name()) << "\n" | |
| << e.what() << std::endl; | |
| << std::format("Caught a bad_any_cast exception: key requested: {}, requested type: {}, actual type: {}\n" , | |
| key, | |
| demangle(typeid(T).name()), | |
| demangle(data.at(key).type().name())) |
| @@ -145,9 +145,9 @@ Vector operator*(const scalar& sclr, Vector rhs) | |||
| } | |||
|
|
|||
| KOKKOS_INLINE_FUNCTION | |||
| Vector operator&(const Vector& lhs, Vector rhs) | |||
| scalar operator&(const Vector& lhs, Vector rhs) | |||
There was a problem hiding this comment.
Maybe it makes sense to have both? preferably i would say this should be implemented in a free function.
Suggested change
| scalar operator&(const Vector& lhs, Vector rhs) | |
| /* @brief dot product */ | |
| scalar operator*(const Vector& lhs, Vector rhs) {return dotProduct(lhs, rhs)} | |
| /* @brief inner product */ | |
| Vector operator&(const Vector& lhs, Vector rhs) {return innerProduct(lhs, rhs)} |
| @@ -0,0 +1,116 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // SPDX-FileCopyrightText: 2023 NeoFOAM authors | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2023 NeoFOAM authors | |
| // SPDX-FileCopyrightText: 2025 NeoFOAM authors |
| @@ -0,0 +1,49 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // SPDX-FileCopyrightText: 2023 NeoFOAM authors | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2023 NeoFOAM authors | |
| // SPDX-FileCopyrightText: 2025 NeoFOAM authors |
| @@ -0,0 +1,70 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // SPDX-FileCopyrightText: 2024 NeoFOAM authors | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2024 NeoFOAM authors | |
| // SPDX-FileCopyrightText: 2025 NeoFOAM authors |
| TEST_CASE("uncorrected") | ||
| { | ||
| const size_t nCells = 10; | ||
| NeoFOAM::Executor exec = GENERATE(NeoFOAM::Executor(NeoFOAM::SerialExecutor {}) |
There was a problem hiding this comment.
Suggested change
| NeoFOAM::Executor exec = GENERATE(NeoFOAM::Executor(NeoFOAM::SerialExecutor {}) | |
| // FIXME: test with all executors | |
| NeoFOAM::Executor exec = GENERATE(NeoFOAM::Executor(NeoFOAM::SerialExecutor {}) |
| @@ -0,0 +1,229 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // SPDX-FileCopyrightText: 2023 NeoFOAM authors | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2023 NeoFOAM authors | |
| // SPDX-FileCopyrightText: 2025 NeoFOAM authors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solve the pressure Equation with icoNeoFOAM