Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implicit BCs and Laplacian operator #262

Open
wants to merge 20 commits into
base: stack/implicitOperators
Choose a base branch
from
Open

implicit BCs and Laplacian operator #262

wants to merge 20 commits into from

Conversation

HenningScheufler
Copy link
Collaborator

@HenningScheufler HenningScheufler commented Feb 15, 2025 •
edited
Loading

Feature

  • Laplacian operator
  • faceNormal Gradients
    - [x] uncorrected
  • adds BCs contriubtion to implicit BCs
    - all boundary are implmented as mixed BC this way the boundary contribution can be computed with one function dispatch
    - [x] laplacian implicit BCs
    - [] div implicit BCs
  • basicGeometric Scheme calculate celltocell distance
  • TokenList are consumed similar to a stream with member function next

Fixes

  • face ordering of 1D mesh
  • boundaryFields valueFraction returned refValue_
  • fixedGradient accessed out of bounds faceCells
  • operators were not scaled within the DSL

@github-actions GitHub Actions
Copy link

Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_262

@HenningScheufler HenningScheufler changed the base branch from main to stack/implicitOperators February 16, 2025 11:33
@HenningScheufler HenningScheufler added enhancement New feature or request ready-for-review Set this label to indicate that the PR is ready for review and removed ready-for-review Set this label to indicate that the PR is ready for review labels Feb 16, 2025
greole
greole approved these changes Feb 25, 2025
View reviewed changes
include/NeoFOAM/finiteVolume/cellCentred/operators/gaussGreenDiv.hpp
@@ -29,31 +29,44 @@ class GaussGreenDiv : public DivOperatorFactory::Register<GaussGreenDiv>


virtual void
div(VolumeField<scalar>& divPhi, const SurfaceField<scalar>& faceFlux, VolumeField<scalar>& phi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what we can do to reduce the amount of variants here is to move the dispatching to dsl/operators.hpp and support only one concrete implementation per ValueType ie. div(span<scalar> out, ), div(span<Vector> out, ) and one for Tensor ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greole greole greole approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenningScheufler @greole