Interpolation for vector fields #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_258 |
b0892b2 to
9c6e27c
Compare
HenningScheufler
approved these changes
Feb 15, 2025
| @@ -33,15 +33,19 @@ class Linear : public SurfaceInterpolationFactory::Register<Linear> | |||
|
|
|||
| static std::string schema() { return "none"; } | |||
|
|
|||
| void interpolate(const VolumeField<scalar>& volField, SurfaceField<scalar>& surfaceField) | |||
| const override; | |||
| void interpolate(const VolumeField<scalar>& src, SurfaceField<scalar>& dst) const override; | |||
There was a problem hiding this comment.
im not source if src and dst are the best names:
more intuitive would be define a variable like phi and phif and make it consistent with the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds interpolation kernels for
Field<Vector>for upwind and linear interpolations. Currently, overloading ofinterpolate(src, dst)is used to implement the functionality on the operator. The reason is that template functions seems to not work well with the runTimeSelection mechanism and the static create functions and the virtual interpolate members.This PR is required for #256.
Additional changes:
volField,surfaceFieldtosrcanddst. To make the purpose clearer.