Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fixme workflow #191

Merged
merged 2 commits into from
Dec 20, 2024
Merged

add fixme workflow #191

merged 2 commits into from
Dec 20, 2024

Conversation

greole
Copy link
Contributor

@greole greole commented Dec 6, 2024

This PR adds a workflow to check for FIXME: notes in the code to avoid accidentally merging unfinished things.

Currently it requires the FIXME note to be followed by a colon, we could however also remove it.

Copy link

github-actions bot commented Dec 6, 2024

Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_191

@greole
Copy link
Contributor Author

greole commented Dec 19, 2024

remove the colon!

this workflow fails if the keyword FIXME is found in the code
@greole greole merged commit 01b9cd6 into main Dec 20, 2024
11 checks passed
@greole greole deleted the ci/fixme branch December 20, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant