Implementation of operator coefficient handler #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2809339 to
aa05d2d
Compare
This was referenced Sep 30, 2024
540f634 to
5b61ea8
Compare
ea7c43c to
24f9cf9
Compare
greole
commented
Oct 4, 2024
| }; | ||
|
|
||
|
|
||
| inline Coeff operator*(const Coeff& lhs, const Coeff& rhs) |
There was a problem hiding this comment.
The coeff would be used inside the Operator and the cases of multiplying two coeff should Not excist
Co-authored-by: Henning Scheufler <henning.scheufler@web.de>
- updates docstrings - fix formating - fix some compilation issues
658de08 to
634568a
Compare
|
@greole |
HenningScheufler
approved these changes
Oct 6, 2024
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a class to handle dslTerm coefficients.
Motivation: In an
eqnSystemwe commonly have things like2*T*operator::div(U) - operator::laplace(U). To keep the ability to lazily evaluate the system the coefficients, namely2*Tand-1need to be stored separately. This is the responsibility of thedslCoefficientclass.Usage: Writing
eqnSystem( -2*T*operator::div(U))would lead to eager evaluation of 2*T.Ideally one would use
eqnSystem(coeff(-2,T)*operator::div(U)). Other combinations likeeqnSystem(coeff(-2) *T*operator::div(U))andeqnSystem(coeff()*-2 *T*operator::div(U))are equivalent. AlsoeqnSystem(2*(T*operator::div(U)))can force lazy evaluation.Internal Usage
An operation like
Type*operator::div(Field)calls theeqnTerm::operator*implementation this passesTypeand creates an instance ofCoeff(Type). In the actual evaluation stepCoeff::operator[]is called which performs the multiplication ofscalar*field[i]if required.Based on: #136
Part of the stack: #102