From da3b32a21a746940468594501bbfa7d3595b3381 Mon Sep 17 00:00:00 2001 From: Gregor Olenik Date: Fri, 6 Dec 2024 22:05:16 +0100 Subject: [PATCH 1/2] add fixme workflow this workflow fails if the keyword FIXME is found in the code --- .github/workflows/static_checks.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/static_checks.yaml b/.github/workflows/static_checks.yaml index 2f8f0bc76..07f577624 100644 --- a/.github/workflows/static_checks.yaml +++ b/.github/workflows/static_checks.yaml @@ -125,3 +125,12 @@ jobs: - uses: dangoslen/changelog-enforcer@v3 with: changeLogPath: CHANGELOG.md + fixmes: + name: FIXME check + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: greole/action-fixme-check@master # or @ the latest release + with: + terms: 'FIXME' # optional, defaults to `FIXME` + case-sensitive: false # optional, defaults to `true` From b2b87f6d973d23e162d0af1a7847253208fbc1f0 Mon Sep 17 00:00:00 2001 From: Gregor Olenik Date: Fri, 20 Dec 2024 10:49:17 +0100 Subject: [PATCH 2/2] make fixme a todo --- test/finiteVolume/cellCentred/operator/divOperator.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/finiteVolume/cellCentred/operator/divOperator.cpp b/test/finiteVolume/cellCentred/operator/divOperator.cpp index ea5daecc3..dcad3ed47 100644 --- a/test/finiteVolume/cellCentred/operator/divOperator.cpp +++ b/test/finiteVolume/cellCentred/operator/divOperator.cpp @@ -26,7 +26,7 @@ TEST_CASE("DivOperator") ); std::string execName = std::visit([](auto e) { return e.print(); }, exec); - // FIXME: take 1d mesh + // TODO: take 1d mesh NeoFOAM::UnstructuredMesh mesh = NeoFOAM::createSingleCellMesh(exec); auto surfaceBCs = fvcc::createCalculatedBCs>(mesh);