Feat/poisson equation #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greole
reviewed
Feb 26, 2025
| @@ -0,0 +1,7 @@ | |||
| # SPDX-License-Identifier: Unlicense | |||
| # | |||
| # SPDX-FileCopyrightText: 2023 NeoFOAM authors | |||
There was a problem hiding this comment.
Suggested change
| # SPDX-FileCopyrightText: 2023 NeoFOAM authors | |
| # SPDX-FileCopyrightText: 2025 NeoFOAM authors |
| @@ -2,3 +2,5 @@ | |||
| # SPDX-FileCopyrightText: 2024 NeoFOAM authors | |||
|
|
|||
| add_subdirectory(scalarAdvection) | |||
| add_subdirectory(icoNeoFoam) | |||
There was a problem hiding this comment.
should we name it neoIcoFoam or icoNeoFoam?
| @@ -0,0 +1,7 @@ | |||
| # SPDX-License-Identifier: Unlicense | |||
| # | |||
| # SPDX-FileCopyrightText: 2023 NeoFOAM authors | |||
There was a problem hiding this comment.
Suggested change
| # SPDX-FileCopyrightText: 2023 NeoFOAM authors | |
| # SPDX-FileCopyrightText: 2025 NeoFOAM authors |
| @@ -32,17 +32,19 @@ bool checkEntryType(const Foam::entry& entry) | |||
| } | |||
| catch (const Foam::IOerror& ioErr) | |||
| { | |||
| FatalError.throwExceptions(false); | |||
There was a problem hiding this comment.
maybe add a docstring/comment what is happening here? Also i think this can be refactored by having a return variable.
Comment on lines
33
to
+42
| catch (const Foam::IOerror& ioErr) | ||
| { | ||
| FatalError.throwExceptions(false); | ||
| FatalIOError.throwExceptions(false); | ||
| return false; | ||
| } | ||
| catch (const Foam::error& err) | ||
| { | ||
| FatalError.throwExceptions(false); | ||
| FatalIOError.throwExceptions(false); |
There was a problem hiding this comment.
Suggested change
| catch (const Foam::IOerror& ioErr) | |
| { | |
| FatalError.throwExceptions(false); | |
| FatalIOError.throwExceptions(false); | |
| return false; | |
| } | |
| catch (const Foam::error& err) | |
| { | |
| FatalError.throwExceptions(false); | |
| FatalIOError.throwExceptions(false); | |
| bool ret {true}; | |
| catch (const Foam::IOerror& ioErr) | |
| { | |
| ret = false; | |
| } | |
| catch (const Foam::error& err) | |
| { | |
| ret = false; | |
| } | |
| FatalError.throwExceptions(false); | |
| FatalIOError.throwExceptions(false); | |
| return ret; | |
Comment on lines
+30
to
+35
|
|
||
| // NeoFOAM::Executor exec = GENERATE( | ||
| // NeoFOAM::Executor(NeoFOAM::SerialExecutor {}), | ||
| // NeoFOAM::Executor(NeoFOAM::CPUExecutor {}), | ||
| // NeoFOAM::Executor(NeoFOAM::GPUExecutor {}) | ||
| // ); |
There was a problem hiding this comment.
Suggested change
| // NeoFOAM::Executor exec = GENERATE( | |
| // NeoFOAM::Executor(NeoFOAM::SerialExecutor {}), | |
| // NeoFOAM::Executor(NeoFOAM::CPUExecutor {}), | |
| // NeoFOAM::Executor(NeoFOAM::GPUExecutor {}) | |
| // ); | |
| // TODO: use generator | |
| // NeoFOAM::Executor exec = GENERATE( | |
| // NeoFOAM::Executor(NeoFOAM::SerialExecutor {}), | |
| // NeoFOAM::Executor(NeoFOAM::CPUExecutor {}), | |
| // NeoFOAM::Executor(NeoFOAM::GPUExecutor {}) | |
| // ); |
| @@ -0,0 +1,67 @@ | |||
| // SPDX-License-Identifier: GPL-3.0-or-later | |||
| // SPDX-FileCopyrightText: 2023 NeoFOAM authors | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2023 NeoFOAM authors | |
| // SPDX-FileCopyrightText: 2025 NeoFOAM authors |
Comment on lines
+9
to
+14
| #include "NeoFOAM/finiteVolume/cellCentred/operators/sparsityPattern.hpp" | ||
|
|
||
|
|
||
| #include "gaussConvectionScheme.H" | ||
| #include "NeoFOAM/core/input.hpp" | ||
| #include "NeoFOAM/dsl/explicit.hpp" |
There was a problem hiding this comment.
Suggested change
| #include "NeoFOAM/finiteVolume/cellCentred/operators/sparsityPattern.hpp" | |
| #include "gaussConvectionScheme.H" | |
| #include "NeoFOAM/core/input.hpp" | |
| #include "NeoFOAM/dsl/explicit.hpp" | |
| #include "gaussConvectionScheme.H" | |
| #include "NeoFOAM/NeoFOAM.hpp" |
| @@ -0,0 +1,64 @@ | |||
| // SPDX-License-Identifier: GPL-3.0-or-later | |||
| // SPDX-FileCopyrightText: 2023 NeoFOAM authors | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2023 NeoFOAM authors | |
| // SPDX-FileCopyrightText: 2025 NeoFOAM authors |
Comment on lines
+28
to
+31
|
|
||
| NeoFOAM::Executor exec = GENERATE(NeoFOAM::Executor(NeoFOAM::SerialExecutor {}) | ||
| // NeoFOAM::Executor(NeoFOAM::CPUExecutor {}), | ||
| // NeoFOAM::Executor(NeoFOAM::GPUExecutor {}) |
There was a problem hiding this comment.
Suggested change
| NeoFOAM::Executor exec = GENERATE(NeoFOAM::Executor(NeoFOAM::SerialExecutor {}) | |
| // NeoFOAM::Executor(NeoFOAM::CPUExecutor {}), | |
| // NeoFOAM::Executor(NeoFOAM::GPUExecutor {}) | |
| // TODO: implement other executors again | |
| NeoFOAM::Executor exec = GENERATE(NeoFOAM::Executor(NeoFOAM::SerialExecutor {}) | |
| // NeoFOAM::Executor(NeoFOAM::CPUExecutor {}), | |
| // NeoFOAM::Executor(NeoFOAM::GPUExecutor {}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solve the pressure Equation with icoNeoFOAM